chore(deps): otel-collector 0.169.0, with the image following the chart - #33
Merged
Conversation
Mirrors eks-gitops 9c7ce04. The chart moves 0.166.0 -> 0.169.0 and the hand-set image tag comes out. Chart 0.166.0 declares appVersion 0.157.0 and this file pinned the image at 0.157.0, so the two agreed by hand; 0.169.0 declares 0.158.0, so bumping the chart alone would have opened a divergence with the chart ahead of the binary it names. mirror-check compares chart versions and nothing else, so it would never have reported that drift — the same blind spot that lets a velero plugin image sit three minors from its counterpart across the two repositories. Deleting the tag removes the second fact rather than adding a check for it: the chart renders `.Values.image.tag | default .Chart.AppVersion`, so the image is now a function of the pin. Rendered output resolves to otel/opentelemetry-collector-contrib:0.158.0, which confirms the default is reached rather than assumed. upstream.ref moves to 9c7ce04, and `mirror-check sync` re-pinned zero slices — the hand-written version already matched what eks-gitops pins. Full check: 32 charts match, 12 declared divergences, 2 CRD installers answered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors eks-gitops#195 (merged as
9c7ce04).Chart
0.166.0→0.169.0, and the hand-set image tag comes out.Why the tag goes
Chart
0.166.0declares appVersion0.157.0and this file pinned the image at0.157.0— agreed, by hand.0.169.0declares0.158.0, so a chart-only bump opens a divergence with the chart ahead of the binary it names.mirror-checkwould never have reported it. It compares chart versions and nothing else. That's the same blind spot that currently letsvelero-plugin-for-awssit three minors apart between kx (v1.11.0) and eks-gitops (v1.14.2) with both sides reporting a match.Deleting the tag removes the second fact rather than adding a check for it. The chart renders
.Values.image.tag | default .Chart.AppVersion, so the image is now a function of the pin.Verification
otel/opentelemetry-collector-contrib:0.158.0— the default is reached, not assumedmirror-check syncre-pinned zero slices; the hand-written version already matched upstreammirror-check check→ 32 charts matcheks-gitops@9c7ce0476cd4, 12 declared divergences, 2 CRD installers answeredrender-check.shOK for the slice, including the per-container mount check