Skip to content

feat(tui): label placeholder rows [CREATE COMMIT] / [CREATE BRANCH] - #285

Merged
narnaud merged 1 commit into
mainfrom
tui-create-tags
Sep 20, 2026
Merged

narnaud merged 1 commit into
mainfrom
tui-create-tags

Conversation

@narnaud

@narnaud narnaud commented Sep 20, 2026

Copy link
Copy Markdown
Owner

A commit being placed and a branch being named have no short ID. They used
to borrow the column with a dim '..', which reads like an unresolved ID; an
inverted tag now says what the row is.

Summary by CodeRabbit

  • New Features

    • Added clear [CREATE COMMIT] and [CREATE BRANCH] labels for pending rows in the terminal interface.
    • Added distinct styling for pending commit and branch tags.
  • Style

    • Simplified commit row displays by removing redundant abbreviated hash placeholders.

@narnaud
narnaud added this pull request to stack #286 September 20, 2026 13:57
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 6acbb499-a057-4b3f-911a-bef44a027e34

📥 Commits

Reviewing files that changed from the base of the PR and between 7e6bad1 and 8d0ea49.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 3e0acb58-7da4-4993-9b2d-4c97f80feff4

📥 Commits

Reviewing files that changed from the base of the PR and between b485b8a and 7e6bad1.

📒 Files selected for processing (4)
  • specs/020-tui.md
  • src/tui/app.rs
  • src/tui/app_test.rs
  • src/tui/theme.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The TUI now renders pending branch and commit rows with explicit styled labels. The theme exposes the label style, and the specification and rendering tests reflect the new output.

Changes

TUI pending row labels

Layer / File(s) Summary
Pending tag style
src/tui/theme.rs
TuiTheme exposes pending_tag. from_graph_theme initializes it with the label color, reversed display, and bold text.
Pending row rendering
src/tui/app.rs, src/tui/app_test.rs, specs/020-tui.md
Branch placeholders render [CREATE BRANCH]. Commit placeholders render [CREATE COMMIT] without a fabricated short ID or padding. Tests and the TUI specification use the updated format.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 7e6ba

Pending commit and branch placeholders retain their existing file-count behavior while displaying the new labels, so no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding [CREATE COMMIT] and [CREATE BRANCH] labels for placeholder TUI rows.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

Base automatically changed from id-column to main September 20, 2026 14:22
A commit being placed and a branch being named have no short ID. They used
to borrow the column with a dim '..', which reads like an unresolved ID; an
inverted tag now says what the row is.
@narnaud
narnaud merged commit e920674 into main Sep 20, 2026
6 checks passed
@narnaud
narnaud deleted the tui-create-tags branch September 20, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant