Skip to content

Update setup.py #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmarshak wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update setup.py #52

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cb0c20
Update setup.py
cmarshak Dec 18, 2023
fb4db98
Update setup.py with gdal
cmarshak Dec 18, 2023
51093d0
Update setup.py - remove gdal again
cmarshak Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def run(self):
scripts=['bin/dswx_hls.py',
'bin/dswx_compare.py'],
install_requires=['argparse', 'numpy', 'yamale',
'osgeo', 'scipy', 'pytest', 'requests'],
'scipy', 'pytest', 'requests'],
Copy link
Collaborator

@nemo794 nemo794 Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osgeo contains access to gdal, which is a necessary dependency for PROTEUS.

If this dependency is removed, and then a user tries to install and run PROTEUS in a fresh conda environment, then it will fail due to the missing dependency.

If this fix worked on your system and you were still able to run PROTEUS, by chance, were you working in an existing conda environment, where osgeo / gdal were previously installed for a different application?

Copy link
Author

@cmarshak cmarshak Dec 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osgeo contains access to gdal, which is a necessary dependency for PROTEUS.

If this dependency is removed, and then a user tries to install and run PROTEUS in a fresh conda environment, then it will fail due to the missing dependency.

If this fix worked on your system and you were still able to run PROTEUS, by chance, were you working in an existing conda environment, where osgeo / gdal were previously installed for a different application?

osgeo is not the proper name for the library listed on PyPI from what I have read and tried locally e.g. https://pypi.org/project/osgeo/

Not negating from osgeo import gdal just highlighting the package name should be updated in setup.py as it is here too: https://github.com/nasa/PROTEUS/blob/main/docker/requirements.txt#L1

Copy link
Author

@cmarshak cmarshak Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried adding gdal but now it's not passing CircleCI - I will let you figure out how to fix this or maybe it's not necessary.

Copy link
Collaborator

@nemo794 nemo794 Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't surprise me that it failed. Please see this comment: #51 (comment)

Updating PROTEUS to be installed via pip and not setup.py would likely be considered a new feature development.

url='https://github.com/opera-adt/PROTEUS',
license='Copyright by the California Institute of Technology.'
' ALL RIGHTS RESERVED.',
Expand Down