Fix #1497, Use CFE_TIME_SysTime_t instead of indiv. sec/subsec members#2246
Open
thnkslprpt wants to merge 1 commit into
Open
Fix #1497, Use CFE_TIME_SysTime_t instead of indiv. sec/subsec members#2246thnkslprpt wants to merge 1 commit into
thnkslprpt wants to merge 1 commit into
Conversation
thnkslprpt
force-pushed
the
fix-1497-use-CFE_TIME_SysTime_t
branch
from
833be46 to
ffb16f1
Compare
|
You have successfully added a new CodeQL configuration |
|
You have successfully added a new CodeQL configuration |
thnkslprpt
force-pushed
the
fix-1497-use-CFE_TIME_SysTime_t
branch
4 times, most recently
from
d9156a5 to
c07bc4c
Compare
thnkslprpt
force-pushed
the
fix-1497-use-CFE_TIME_SysTime_t
branch
3 times, most recently
from
31fcd1a to
7564666
Compare
thnkslprpt
force-pushed
the
fix-1497-use-CFE_TIME_SysTime_t
branch
2 times, most recently
from
b3854a1 to
ec60708
Compare
thnkslprpt
force-pushed
the
fix-1497-use-CFE_TIME_SysTime_t
branch
from
ec60708 to
ff57c16
Compare
Contributor
Author
|
Partially implemented in #2544 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_TIME_SysTime_tinstead of individual Seconds/subseconds #1497uint32) members representing seconds/sub-seconds for file creation time were converted to use the unifiedCFE_TIME_SysTime_ttype in 7 locations.Testing performed
All tests were passing before changes to
CFE_FS_Header_twere added (see https://github.com/nasa/cFE/actions/runs/4585928750 and https://github.com/nasa/cFE/actions/runs/4585928751).The functional test and CodeQL analyses are no longer able to build because elf2cfetbl references the old
uint32members inCFE_FS_Header_tdirectly, so an additional PR for elf2cfetbl is required at the same time - see nasa/elf2cfetbl#134.Local tests with full cFS package confirm all tests passing when both changes are made together, and net coverage unaffected.
Note: If this is merged it will require updates to some of the txt files in the Ground System tool to ensure clean and correct interpretation of the data members.
System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.
Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt