Skip to content

Backport node10 - #1394

Merged
Jkovarik merged 9 commits into
release-1.14.xfrom
backport-node10
Dec 19, 2019
Merged

Backport node10#1394
Jkovarik merged 9 commits into
release-1.14.xfrom
backport-node10

Conversation

@Jkovarik

@Jkovarik Jkovarik commented Dec 17, 2019

Copy link
Copy Markdown
Member

Summary: PR backports code already pulled into master from #1393

Addresses CUMULUS-1626

Changes

  • CUMULUS-1626
    • Updates Cumulus to use node10/CMA 1.1.2 for all of it's internal lambdas in prep for AWS node 8 EOL

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Adhoc testing
  • Integration tests

@Jkovarik

Jkovarik commented Dec 17, 2019

Copy link
Copy Markdown
Member Author

This PR updates the following:

  • All references to node 8.10 to the same version of node code is running in for our AWS Lambdas.
  • AWS SDK to 2.585.0
  • Updates the es indexer to handle extra fields in AWS Linux 2's logs, adds a logic-specific unit test around that logic
  • Updates all references to cumulus-message-adapter.js to utilize v1.1.0
  • Updates the CMA image target to a layer that uses v1.1.2
  • Updates JSFTP to utilize a fork with multiple fixes related to node10/etc (there is a ticket to move fully from this library)
  • Updates libraries that were throwing test-failing deprecation warnings under node 10.

This should be equivalent to the already-approved #1393

@@ -1,4 +1,4 @@
FROM node:8.10
FROM node:10.16.3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to release an updated version of the async-operation image to Docker Hub.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and updated 4095166

@ghost ghost removed the needs review label Dec 18, 2019
Comment thread CHANGELOG.md
Comment thread example/package.json
Comment thread packages/api/es/indexer.js Outdated
Co-Authored-By: Mark Boyd <markdavidboyd@gmail.com>
@Jkovarik
Jkovarik merged commit b7dd9b5 into release-1.14.x Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants