Skip to content

Fix #91, Redo SymbolNames malloc to remove out-of-bounds write#122

Open
thnkslprpt wants to merge 1 commit into
nasa:mainfrom
thnkslprpt:fix-91-remove-outofbounds-write-from-SymbolNames-malloc
Open

Fix #91, Redo SymbolNames malloc to remove out-of-bounds write#122
thnkslprpt wants to merge 1 commit into
nasa:mainfrom
thnkslprpt:fix-91-remove-outofbounds-write-from-SymbolNames-malloc

Conversation

@thnkslprpt

@thnkslprpt thnkslprpt commented Oct 28, 2022

Copy link
Copy Markdown
Contributor

Checklist

Describe the contribution

Testing performed
Just GitHub CI Actions so far.

Expected behavior changes
Logic stays the same, but the possibility of an out-of-bounds write is removed.

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-91-remove-outofbounds-write-from-SymbolNames-malloc branch from de20b36 to eef7cf8 Compare October 28, 2022 19:22
@dzbaker dzbaker requested a review from chillfig November 3, 2022 18:37
@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022

@jphickey jphickey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right ... where did the call to fgetc() go?

I also don't see a buffer overrun in the original. It may write to the last char, but that's OK, as it ensures its got a null term afterward. Doesn't seem like the original code was broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Out-of-bounds Write for VerboseStr

4 participants