Fix #85, Add checks for all return values from fseek()#123
Open
thnkslprpt wants to merge 1 commit into
Open
Conversation
jphickey
requested changes
May 23, 2024
jphickey
left a comment
Contributor
There was a problem hiding this comment.
See comment, need to double check expected return values from fseek calls
|
|
||
| Status = fseek(SrcFileDesc, SeekOffset, SEEK_SET); | ||
|
|
||
| if (Status != 0) |
Contributor
There was a problem hiding this comment.
Shouldn't this be comparing to SeekOffset, not 0? fseek() returns the actual offset in the file on success, or -1 on error. So alternatively it could check for Status < 0. But I think != 0 is incorrect.
Contributor
Author
There was a problem hiding this comment.
@jphickey
Hi Joe - can you point me to the documentation for fseek() that describes that? - I was definitely under the impression that it returns 0 on success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
fseek()in 5 locations where this was absent.Note: in these cases, an error return from
fseek()seems extremely unlikely (unless the input data is corrupted somehow) so these checks are mostly just to squash the warnings.Testing performed
GitHub CI actions (incl. Codeql Build etc.) all passing successfully excl. CodeQL-security for apparently pre-existing issues that are being flagged now.
Expected behavior changes
In cases of error (non-zero) return from
fseek()the error info will be printed and early return withFAILEDwill occur.Contributor Info
Avi Weiss @thnkslprpt