Removes backoff_jitter from the Retry configuration.#121
Conversation
This keyword was added to urllib3 in v2.0.0.
|
Not sure what people think. I could check the urllib version and add it to the Request kwargs. But I'm not sure how important it is it just increases the back off time by |
owenlittlejohns
left a comment
There was a problem hiding this comment.
I followed the test instructions and could both replicate the error and show that removing backoff_jitter allowed a harmony.Client object to be instantiated. Nice.
Initially, I was a bit concerned that we don't have a unit test that caught this. But I think it's because urllib3 v2.x has been available for a few years, and is compatible with all the Python versions the CI/CD uses to execute unit tests. So we'd have to create an entirely separate environment to force the urllib3 version down to 1.26.x just for this case (seems overkill).
While I think this change makes sense, the feedback to end-users probably should still be to upgrade to urllib3 v2.x in their environments where possible. (Looks one reason for still being on v1.x is if running Python 3.9 and using boto3)
Jira Issue ID
None
Description
Removes backoff_jitter from the Retry() call.
This keyword was added to urllib3 in v2.0.0. Some users are running into issues, unable to initialize a Client with urllib3 < 2.
I don't want to dig around to handle multiple library versions. I'm proposing to just nuke this option.
Error case
Success case (after installing this branch's built package)
Local Test Steps
Run Tests. 🤞
Build this package, create an environment with urllib3<2, install the package and instantiate a Request() object like demonstrated above.
PR Acceptance Checklist
Tests added/updated (if needed) and passingDocumentation updated (if needed)