Nos3#519 underscore instead of dash#701
Merged
Merged
Conversation
…ks as of this commit, I believe
…ong a few other things
…iner (DNS) names now
… the nos_time_driver to nos-time-driver
This was referenced May 20, 2025
kevincbruce
requested review from
Donnie-Ice,
dacarter22,
dccutrig,
jlucas9,
kevincbruce,
msuder,
rjbrown2,
szemerick and
zlynch2
Contributor
|
Will try more tomorrow, but was trying to run science mode and system tests with it. Don't believe Science mode triggered (though not 100% sure) and some system tests worked, some did not. Though I may have needed more set up for some of the ones that broke, so probably working. Will approve once I get to test again and confirm. |
kevincbruce
approved these changes
May 21, 2025
kevincbruce
left a comment
kevincbruce
left a comment
Contributor
There was a problem hiding this comment.
Confirmed some system tests, science mode, radio tlm output, and some other features worked in this new build, so I'm fairly confident that nothing got broken with the renaming.
haisamido
reviewed
May 28, 2025
added 2 commits
May 28, 2025 13:34
# Conflicts: # docs/wiki/Architecture.md # docs/wiki/NOS3_Architecture.md # docs/wiki/NOS3_Install_Build_Run_QuickStart.md # scripts/ci_launch.sh
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #701 +/- ##
==========================================
+ Coverage 72.88% 73.95% +1.06%
==========================================
Files 748 761 +13
Lines 92138 93581 +1443
Branches 6976 6984 +8
==========================================
+ Hits 67157 69207 +2050
+ Misses 24981 24374 -607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjbrown2
approved these changes
May 30, 2025
zlynch2
approved these changes
May 30, 2025
zlynch2
left a comment
zlynch2
left a comment
Collaborator
There was a problem hiding this comment.
verified containers use dash not underscore. NOS3 launches. approving.
vedantt21
pushed a commit
to vedantt21/nos3-mantle
that referenced
this pull request
Feb 18, 2026
* [nasa#519] Updates to (mostly if not entirely yet) remove _ and replace it with - * [nasa#519] Updates to get the thruster compiling properly and such * [nasa#519] Updates to remove underscores from more things; everything works as of this commit, I believe * [nasa#519] Replacing underscores with dashes in radio_sim and nos_fsw, among a few other things * [nasa#519] Changing the network names to no longer use sc_1_ but to be sc01- instead * [nasa#519] Further updates and alterations to replace _ with -, for container (DNS) names now * [nasa#519] Updates to change the name of the COSMOS container, as well as the nos_time_driver to nos-time-driver * [nasa#519] Updates to switch to nos-engine-server instead of nos_engine_server * [nasa#519] Removing erroneously added files * [nasa#519] Updates to submodules * [nasa#519] Updating the documentation * [nasa#519] Updates after PR review and submodule merges; --------- Co-authored-by: Harris <dbharri5@ndc.nasa.gov> Co-authored-by: Lucas, John P. <John.P.Lucas@nasa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will also require merging changes in the following submodules:
To test:
Just ensure that NOS3 works and that commands/telemetry/data all work as they normally would.