[nasa/nos3#731] fprime components fidelity#739
Conversation
KushalP17
requested review from
a team,
Donnie-Ice,
Isgaroth-the-Green,
dccutrig,
jlucas9,
kevincbruce,
msuder,
rjbrown2,
szemerick and
zlynch2
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #739 +/- ##
=======================================
Coverage 73.95% 73.95%
=======================================
Files 761 761
Lines 93579 93579
Branches 6983 6983
=======================================
Hits 69207 69207
Misses 24372 24372 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zlynch2
left a comment
zlynch2
left a comment
There was a problem hiding this comment.
So far looks good, please go through and update os_printf() calls with the fprime event message calls, that way we see the messages in fprime-gds. especially if the device is disabled. I saw this on the fss and I am working my way through the others too.
jlucas9
left a comment
jlucas9
left a comment
There was a problem hiding this comment.
Approved pending other corrections recommended resolved.
|
Should be cleared of os_printf calls now |
zlynch2
left a comment
zlynch2
left a comment
There was a problem hiding this comment.
reviewed each component, with modifications. Added Functionality is good. Approving. also removed os_printf().
* [nasa#731] fprime css fidelity * [nasa#731] css data work only when enable * [nasa#731] fprime fss fidelity * [nasa#731] fix enable state fss & css * [nasa#731] fprime fidelity imu * [nasa#731] noop shows enable state css,fss,imu * [nasa#731] fprime fidelity mag * [nasa#731] fprime fidelity reaction wheel * [nasa#731] fprime fidelity star tracker * [nasa#731] fprime fidelity thruster * [nasa#731] fprime fidelity radio * [nasa#731] remove os_printfs * [nasa#731] Updates after PR review; --------- Co-authored-by: Lucas, John P. <John.P.Lucas@nasa.gov>
4 participants
Added all remaining telemetry & commands for the following components:
CSS
FSS
IMU
MAG
Reaction Wheel
Star Tracker
Thruster
Radio
(Mostly) all components should start disabled
How to Test:
Merge PR#729 before this one
Submodules to be merged:
fprime-nos3 - 731-fprime_components_fidelity
generic_css - 731-fprime_components_fidelity
generic_fss - 731-fprime_components_fidelity
generic_imu - 731-fprime_components_fidelity
generic_magnetometer - 731-fprime_components_fidelity
generic_reaction_wheel - 731-fprime_components_fidelity
generic_star_tracker - 731-fprime_components_fidelity
generic_thruster - 731-fprime_components_fidelity
generic_radio - 731-fprime_components_fidelity
Closes #731
Closes #732