853 document multiple spacecraft scenario#855
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #855 +/- ##
==========================================
- Coverage 72.75% 72.06% -0.69%
==========================================
Files 761 761
Lines 90262 91123 +861
Branches 7137 7289 +152
==========================================
Hits 65668 65668
- Misses 24594 25455 +861 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Isgaroth-the-Green
left a comment
There was a problem hiding this comment.
Everything looks good, so approving.
mattilynwalker
left a comment
There was a problem hiding this comment.
Might want to add a note regarding the error message after make prep "using duplicate spacecraft config files, changes will not be saved." to be ignored.
Recent changes to 435 branch should fix this. These changes will be rolled into the ITC repo where we are checkpointing the multiple spacecraft config. |
jennifer-opalko
left a comment
There was a problem hiding this comment.
After knowing to ignore the error message about using duplicate spacecraft config files, everything worked as it should
zlynch2
left a comment
There was a problem hiding this comment.
approving. branch works no errors on sc01-sc03. proximity forward works.
changes requested have been pushed to appropriate branches. you can pull the multiple spacecraft branch and verify as well.
Summary of PR goals.
How to test?
Scenario_Multiple_Spacecraft.mdfileSubmodule PRs and actions prior to closing this:
Note: the multiple spacecraft scenario is checkpointed in its own ITC repo here: https://github.com/nasa-itc/nos3-multiple-spacecraft
This repo is based on the 435 branch here: https://github.com/nasa/nos3/tree/435-42-support-multiple-satellites
Closes #853.