Skip to content

853 document multiple spacecraft scenario#855

Merged
zlynch2 merged 4 commits into
devfrom
853-document-multiple-spacecraft-scenario
Jun 15, 2026
Merged

853 document multiple spacecraft scenario#855
zlynch2 merged 4 commits into
devfrom
853-document-multiple-spacecraft-scenario

Conversation

@msuder

@msuder msuder commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary of PR goals.

How to test?

  • View the Scenario_Multiple_Spacecraft.md file
  • Follow the instructions in that file and verify that everything works as described

Submodule PRs and actions prior to closing this:

Closes #853.

@msuder msuder requested a review from zlynch2 June 11, 2026 16:49
@msuder msuder self-assigned this Jun 11, 2026
@codecov-commenter

codecov-commenter commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.06%. Comparing base (6f2e4a2) to head (fbb4177).
⚠️ Report is 52 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #855      +/-   ##
==========================================
- Coverage   72.75%   72.06%   -0.69%     
==========================================
  Files         761      761              
  Lines       90262    91123     +861     
  Branches     7137     7289     +152     
==========================================
  Hits        65668    65668              
- Misses      24594    25455     +861     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, so approving.

@mattilynwalker mattilynwalker left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add a note regarding the error message after make prep "using duplicate spacecraft config files, changes will not be saved." to be ignored.

@zlynch2

zlynch2 commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Might want to add a note regarding the error message after make prep "using duplicate spacecraft config files, changes will not be saved." to be ignored.

Recent changes to 435 branch should fix this. These changes will be rolled into the ITC repo where we are checkpointing the multiple spacecraft config.

@jennifer-opalko jennifer-opalko left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After knowing to ignore the error message about using duplicate spacecraft config files, everything worked as it should

@zlynch2 zlynch2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving. branch works no errors on sc01-sc03. proximity forward works.

@zlynch2 zlynch2 dismissed mattilynwalker’s stale review June 15, 2026 20:03

changes requested have been pushed to appropriate branches. you can pull the multiple spacecraft branch and verify as well.

@zlynch2 zlynch2 merged commit 45456ed into dev Jun 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants