Add spacewasi crate#26
Merged
Merged
Conversation
Code Coverage ReportCurrent Coverage: 94.59% |
CoreMark Benchmark ResultsCurrent Score: 256.690 |
cole-wilson
marked this pull request as ready for review
July 9, 2026 23:29
Collaborator
Author
|
Checks are currently failing due to the use of llvm and wasi-sdk for compiling the wasi test cases, and it is not installed on the runner yet. |
Kronos3
requested changes
Jul 14, 2026
Kronos3
left a comment
Kronos3
left a comment
Contributor
There was a problem hiding this comment.
Looks generally good, I had a couple notes on error handling and other minor things.
Contributor
|
@cole-wilson You may also want to sync up with the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an implementation of the
wasi_snapshot_preview1WASI bindings and a command line binary to run arbitrary WASI mvp modules.This crate uses wasmtime's internal binding functions for the actual WASI implementations, from the
wasi-commoncrate.Future extension is possible for
preview2through the same interface.There is also a simple
make_mvpbash script which "lowers" WASM binaries to MVP levels that can be run in spacewasm.