fix: use {"mcpServers":{}} instead of {} for empty MCP config#440
Open
sebastiankraska wants to merge 1 commit into
Open
fix: use {"mcpServers":{}} instead of {} for empty MCP config#440sebastiankraska wants to merge 1 commit into
sebastiankraska wants to merge 1 commit into
Conversation
|
thanks a lot!wish this pr merged as soon as possible ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #437
Note
I am not a Rust developer. I used Claude Code to fix this.
What I experienced
Clicking Test connection under Settings > LLM Models > Claude Code CLI (local) failed with:
This happened regardless of the "Isolate local CLI configuration" toggle.
Root cause
When the connection test runs with isolation enabled, LLM Wiki passes
--mcp-config {}to the Claude CLI.Newer versions of Claude CLI validate that the JSON contains a
mcpServerskey.{}leaves it asundefined, which fails schema validation.Fix
Pass
{"mcpServers":{}}instead of{}. The config is still empty (no MCP servers), but the required key is now explicitly present. Updated the unit test to match.Verified
After the fix, Test connection succeeds: Connected in 2450 ms. Response: Ready