feat: add Brave Search as a web search provider#489
Merged
Conversation
Add Brave Web Search API as a new search provider option. Includes API key validation, 20-result ceiling clamping, auth error guidance, and full test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds Brave Search API as a web search provider alongside Tavily, SerpApi, SearXNG, Ollama, and Firecrawl.
Changes
src/stores/wiki-store.ts— adds"brave"toSearchProviderunion typesrc/lib/web-search.ts— implementsbraveSearch(), routes the switch case, updates the API-key validation error to mention Bravesrc/components/settings/sections/web-search-section.tsx— adds Brave Search entry to the provider list in Settingssrc/lib/web-search.test.ts— three new tests: happy path with header/result normalization, 20-result count cap, 401 auth error surfaceImplementation details
X-Subscription-Token: <api_key>(Brave's published scheme, distinct fromAuthorization: Bearer)GET https://api.search.brave.com/res/v1/web/searchcountis clamped to[1, 20]— Brave silently caps higher values server-side; clamping client-side keeps the URL honest and avoids surprising callersdata.web.results[] → { title, url, snippet: description, source: hostnameFromUrl(url) }— same shape as existing providersisFetchNetworkError(), generic HTTP error with status + bodyTest plan
npx tsc --noEmitpasses