feat: use system font stack for better CJK rendering#498
Open
fordchao wants to merge 1 commit into
Open
Conversation
Replace the Geist Variable font with system default font stack to improve rendering for Chinese/Japanese/Korean (CJK) users. The new font stack falls back to Pingfang SC on macOS and Microsoft YaHei on Windows, which look more natural for CJK text. Closes: nashsu/llm_wiki/issues (if any)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hardcoded
Geist Variablefont with a system default font stack to improve text rendering for Chinese/Japanese/Korean (CJK) users.Changes
@import "@fontsource-variable/geist"(no longer needed)--font-sans: 'Geist Variable', sans-serifwith system font stack:Why
Geistis designed primarily for Latin characters. For CJK users (Chinese/Japanese/Korean), system fonts likePingfang SC(macOS) andMicrosoft YaHei(Windows) provide much better readability and a more native feel.The system font stack is also slightly faster (no extra font file to download) and respects the user's OS preferences.
Testing
Tested locally on macOS (aarch64) with Chinese text — rendering is noticeably more natural.
Closes: #