fix: check ERC20 transfer return value in executeWithdrawal()#6
Open
FoxPink wants to merge 1 commit into
Open
Conversation
- Bug fix: USDT returns false instead of reverting on failure; the contract would mark withdrawal as Executed despite funds not being sent - Add require on IERC20.transfer() return value - Gas: cache registry address in memory in _updateRegistryState() and createEscrow()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix: Silent ERC20 Transfer Failure
\executeWithdrawal()\ calls \IERC20(token).transfer(to, amount)\ without checking the return value. Tokens like USDT (common on Base) return \ alse\ instead of reverting on failure, causing the withdrawal to be marked as \Executed\ while funds remain in the treasury.
Fix: Check the return value of .transfer()\ and revert if it returns \ alse.
Gas Optimization
egistry\ address in memory in _updateRegistryState()\ and \createEscrow()\ to avoid unnecessary SLOADs
Testing