Combine C/Rust compile into one cached Docker image - #105
Closed
nathan-probert wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Closing per discussion: the deploy speedup (19m -> ~1m) came from #104's artifact reuse. This PR adds complexity (Docker image + cache) with no CI-time benefit and a slower cold setup, and the toolchain-consistency/glibc benefits aren't needed right now. Can reopen later if desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds both native extensions in a single manylinux_2_28 container so the compiler toolchain is installed once and cached, replacing the two separate amazonlinux (C) + manylinux (Rust) containers.
build_scripts/Dockerfile: gcc/make + pinned Rust 1.85 onmanylinux_2_28(glibc-2.28 baseline, Lambda-safe artifacts).build_scripts/build.sh: one container compiles C (make compile_c) and Rust (cargo build --target x86_64-unknown-linux-gnu); builds the image on first local use.build_scripts/compile.shandbuild_scripts/rust_compile.sh;deploy.shnow callsbuild.sh.setupjob: builds the image with Docker BuildKit (cache-from/to: type=gha, docker-container driver) so the toolchain only installs once per cache lifetime. Artifact layout and downstreamtest/deployreuse are unchanged.