Migrate test suite from JUnit 4 to JUnit 5 - Fixed build issues with JEPTest migration - #10
Merged
Conversation
Co-authored-by: nathanfunk <3503769+nathanfunk@users.noreply.github.com>
…aturalLogarithmTest Co-authored-by: nathanfunk <3503769+nathanfunk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate to jUnit 5
Migrate test suite from JUnit 4 to JUnit 5 - Initial implementation with 2 successful migrations
Aug 16, 2025
nathanfunk
approved these changes
Aug 16, 2025
nathanfunk
marked this pull request as ready for review
August 16, 2025 15:10
Owner
|
@copilot - please address the remaining build issues |
Co-authored-by: nathanfunk <3503769+nathanfunk@users.noreply.github.com>
Contributor
Author
Fixed the build issues by completing the migration of JEPTest to JUnit 5. The class had conflicting JUnit 4 and 5 patterns causing a constructor constraint violation. Removed the extends TestCase inheritance, eliminated the duplicate constructor, and updated the main method. All tests now pass (201 tests, 0 failures). Commit: 380c832 |
Copilot
AI
changed the title
Migrate test suite from JUnit 4 to JUnit 5 - Initial implementation with 2 successful migrations
Migrate test suite from JUnit 4 to JUnit 5 - Fixed build issues with JEPTest migration
Aug 16, 2025
nathanfunk
approved these changes
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the migration from JUnit 4 to JUnit 5 for the test suite, establishing a proven migration workflow and successfully migrating test classes while resolving critical build issues.
Changes Made
Fixed Build Issues
Resolved critical build failure caused by incomplete JUnit 5 migration in
JEPTestclass:extends TestCaseinheritance that violated JUnit 5 constraintsJUnit 5 Dependencies
Updated
pom.xmlto include JUnit 5 Jupiter dependencies alongside existing JUnit 4:junit-jupiter-api5.11.1 - JUnit 5 API for test annotations and assertionsjunit-jupiter-engine5.11.1 - JUnit 5 test execution enginejunit-vintage-engine5.11.1 for backward compatibility with JUnit 4 testsSuccessfully Migrated Test Classes
Three test classes have been fully migrated to JUnit 5:
Migration Pattern
The proven migration workflow:
extends TestCaseinheritance@Testannotations to test methods@BeforeEachfor setup methodsAssert.*withAssertions.*callsTest Results
The build now succeeds completely with all functionality validated through both basic and advanced example execution.
Addressing #9.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.