Skip to content

Implement conditional GPG signing in CI builds to preserve validation while handling missing secrets #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanfunk merged 3 commits into from
Aug 10, 2025
Merged

Implement conditional GPG signing in CI builds to preserve validation while handling missing secrets #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36aa030
Initial plan
Copilot Aug 10, 2025
0a9441f
Fix GPG signing issue in CI build by skipping GPG and JavaDoc generation
Copilot Aug 10, 2025
2d18e4a
Configure CI to run GPG signing and JavaDoc when secrets are available
Copilot Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,31 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up JDK 17
uses: actions/setup-java@v1
uses: actions/setup-java@v3
with:
java-version: 17
- name: Build with Maven
distribution: 'temurin'
cache: 'maven'
gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }}
gpg-passphrase: MAVEN_GPG_PASSPHRASE
if: ${{ secrets.GPG_PRIVATE_KEY != '' }}
- name: Set up JDK 17 (without GPG)
uses: actions/setup-java@v3
with:
java-version: 17
distribution: 'temurin'
cache: 'maven'
if: ${{ secrets.GPG_PRIVATE_KEY == '' }}
- name: Build with Maven (with GPG)
env:
MAVEN_GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
run: mvn clean install
if: ${{ secrets.GPG_PRIVATE_KEY != '' }}
- name: Build with Maven (skip GPG)
run: mvn clean install -Dgpg.skip=true
if: ${{ secrets.GPG_PRIVATE_KEY == '' }}

- name: Archive production artifacts
uses: actions/upload-artifact@v4
Expand Down