Open
Conversation
nathanielc
requested changes
Nov 24, 2021
app/components/spells.tsx
Outdated
| }; | ||
| const SpellList = withDatabase(withObservables([], ({ database }) => ({ | ||
|
|
||
| const SpellList = (['id'], ({ database }) => ({ |
Owner
There was a problem hiding this comment.
This part doesn't look quite right, the withDatabase and withOberservables function calls should still be in place.
The function calls should look like this:
const SpellList = withDatabase(withObservables([], ({ database }) => ({
spells: database.collections.get('spells').query().observe(),
}))(_SpellList));
nathanielc
approved these changes
Dec 10, 2021
Owner
|
@murdybirdy I rebased the changes off my server changes and added the missing new bits that were needed because of my changes This is good to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.