test: intentionally broken lightshow submission (NAT-131)#55
test: intentionally broken lightshow submission (NAT-131)#55
Conversation
Adds a lightshow entry with these intentional errors: - Missing `audio` frontmatter field (required for lightshows) - Missing `.fseq` file (required file type) - Invalid tag `fake-tag` (not in tags.yaml) - Bad slug with uppercase and underscores (Test_Broken_Lightshow) Part of NAT-131 to verify validation pipeline catches errors. Co-Authored-By: Paperclip <noreply@paperclip.ing>
CI Results ✓ (Expected Failures)Both
Note on missing
|
tallnato
left a comment
There was a problem hiding this comment.
PR Review — Approved ✅
This test PR accomplishes its stated goal. CI correctly catches 3 of 4 intentional validation errors:
| Error | Caught | Notes |
|---|---|---|
Bad slug (Test_Broken_Lightshow) |
✅ | Uppercase + underscores flagged |
Invalid tag (fake-tag) |
✅ | Not in tags.yaml |
Missing audio field |
✅ | Required frontmatter field |
Missing .fseq file |
❌ | Validator checks extensions, not required file types |
Observations:
- PR structure follows the expected
slug.md+slug/directory pattern validate-single-component.ymlcorrectly passed (only lightshows touched)- The
.fseqgap is a real validator limitation worth tracking separately - No security concerns, no secrets in the diff
Recommendation: Merge as-is for CI validation documentation, or close without merge if test data shouldn't persist on main. The fake test-audio.mp3 (plain text "fake audio data") should not land on main long-term.
Summary
audiofield — required for lightshows category.fseqfile — required file type for lightshowsfake-tag— not present incontent/tags.yamlTest_Broken_Lightshow— uses uppercase and underscores instead of lowercase-hyphensExpected outcome
validate-pr.ymlandvalidate-lightshows.ymlshould failvalidate-single-component.ymlshould pass (only one collection touched)Test plan
🤖 Generated with Claude Code
Co-Authored-By: Paperclip noreply@paperclip.ing