Skip to content

test: intentionally broken locksound submission [NAT-132]#56

Open
tallnato wants to merge 1 commit intomainfrom
paperclip/backelino/NAT-132
Open

test: intentionally broken locksound submission [NAT-132]#56
tallnato wants to merge 1 commit intomainfrom
paperclip/backelino/NAT-132

Conversation

@tallnato
Copy link
Copy Markdown
Member

Summary

  • Adds a test locksound entry (content/_locksounds/test-broken-locksound/) with 4 intentional validation errors to verify the CI validation pipeline catches them
  • Wrong audio format (.mp3 instead of required .wav)
  • Missing files field in frontmatter
  • Oversized .wav file (1.1 MB, limit is 1 MB)
  • Missing audio field in frontmatter

Expected CI Behavior

Both validate-pr.yml and validate-locksounds.yml should fail with these errors:

locksounds/test-broken-locksound/broken-sound.mp3: invalid file type ".mp3" (allowed: .wav)
locksounds/test-broken-locksound/oversized-sound.wav: file too large (1.1 MB, max 1 MB)
locksounds/test-broken-locksound.md: missing required field "files"
locksounds/test-broken-locksound.md: missing required field "audio"

Test plan

  • Local validation confirms all 4 errors detected
  • CI Validate PR workflow fails
  • CI Validate Locksounds Content workflow fails
  • Results documented in PR comments

🤖 Generated with Claude Code

Adds a test locksound entry with 4 intentional errors:
- Wrong audio format (.mp3 instead of required .wav)
- Missing `files` field in frontmatter
- Oversized .wav file (1.1 MB, limit is 1 MB)
- Missing `audio` field in frontmatter

Co-Authored-By: Paperclip <noreply@paperclip.ing>
@github-actions github-actions bot added the lock-sounds Changes to lock sounds content label Mar 27, 2026
@tallnato
Copy link
Copy Markdown
Member Author

CI Results ✅ (Expected Failures)

Both validation workflows failed as expected:

Check Status Notes
Validate PR (validate-pr.yml) ❌ Failed Caught all 4 errors
Validate Locksounds (validate-locksounds.yml) ❌ Failed Caught all 4 errors
Semantic PR ✅ Passed
Label ✅ Passed
Single Component Check ✅ Passed

Validation errors detected:

  1. locksounds/test-broken-locksound/broken-sound.mp3: invalid file type ".mp3" (allowed: .wav)
  2. locksounds/test-broken-locksound/oversized-sound.wav: file too large (1.1 MB, max 1 MB)
  3. locksounds/test-broken-locksound.md: missing required field "files"
  4. locksounds/test-broken-locksound.md: missing required field "audio"

Conclusion: The validation pipeline correctly catches all 4 intentional errors in this locksound submission.

Copy link
Copy Markdown
Member Author

@tallnato tallnato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approve ✅

This test PR achieves exactly what it set out to do — submit intentionally broken locksound content and verify the CI validation pipeline catches all errors.

Correctness

All 4 intentional errors are present and accounted for:

# Error Verified in CI
1 Wrong audio format (.mp3 instead of .wav) invalid file type ".mp3" (allowed: .wav)
2 Missing files field in frontmatter missing required field "files"
3 Oversized .wav file (1.1 MB > 1 MB limit) file too large (1.1 MB, max 1 MB)
4 Missing audio field in frontmatter missing required field "audio"

CI Results

  • Validate PR (validate-pr.yml): Failed as expected — 4 errors across 24 items / 5 categories
  • Validate Locksounds Content (validate-locksounds.yml): Failed as expected — 4 errors across 7 items / 1 category
  • Label PRs: Passed (labels applied correctly)
  • Validate Single Component: Passed (expected — this checks structure, not content validity)
  • Semantic PR: Passed (commit message format is correct)

Security

No secrets, credentials, or sensitive data in the diff. Binary files are test fixtures only.

Notes

  • The frontmatter markdown file is clean and clearly documents the intentional errors
  • PR description is thorough with expected error output
  • This PR should not be merged — it's a validation test. Consider closing it after CI results are documented, or marking it as a draft.

LGTM for its stated purpose. Reviewed by @Revinaldo (PR Engineer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lock-sounds Changes to lock sounds content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant