test: intentionally broken locksound submission [NAT-132]#56
Open
test: intentionally broken locksound submission [NAT-132]#56
Conversation
Adds a test locksound entry with 4 intentional errors: - Wrong audio format (.mp3 instead of required .wav) - Missing `files` field in frontmatter - Oversized .wav file (1.1 MB, limit is 1 MB) - Missing `audio` field in frontmatter Co-Authored-By: Paperclip <noreply@paperclip.ing>
Member
Author
CI Results ✅ (Expected Failures)Both validation workflows failed as expected:
Validation errors detected:
Conclusion: The validation pipeline correctly catches all 4 intentional errors in this locksound submission. |
tallnato
commented
Mar 27, 2026
Member
Author
tallnato
left a comment
There was a problem hiding this comment.
Review: Approve ✅
This test PR achieves exactly what it set out to do — submit intentionally broken locksound content and verify the CI validation pipeline catches all errors.
Correctness
All 4 intentional errors are present and accounted for:
| # | Error | Verified in CI |
|---|---|---|
| 1 | Wrong audio format (.mp3 instead of .wav) |
✅ invalid file type ".mp3" (allowed: .wav) |
| 2 | Missing files field in frontmatter |
✅ missing required field "files" |
| 3 | Oversized .wav file (1.1 MB > 1 MB limit) |
✅ file too large (1.1 MB, max 1 MB) |
| 4 | Missing audio field in frontmatter |
✅ missing required field "audio" |
CI Results
- Validate PR (
validate-pr.yml): Failed as expected — 4 errors across 24 items / 5 categories - Validate Locksounds Content (
validate-locksounds.yml): Failed as expected — 4 errors across 7 items / 1 category - Label PRs: Passed (labels applied correctly)
- Validate Single Component: Passed (expected — this checks structure, not content validity)
- Semantic PR: Passed (commit message format is correct)
Security
No secrets, credentials, or sensitive data in the diff. Binary files are test fixtures only.
Notes
- The frontmatter markdown file is clean and clearly documents the intentional errors
- PR description is thorough with expected error output
- This PR should not be merged — it's a validation test. Consider closing it after CI results are documented, or marking it as a draft.
LGTM for its stated purpose. Reviewed by @Revinaldo (PR Engineer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content/_locksounds/test-broken-locksound/) with 4 intentional validation errors to verify the CI validation pipeline catches them.mp3instead of required.wav)filesfield in frontmatter.wavfile (1.1 MB, limit is 1 MB)audiofield in frontmatterExpected CI Behavior
Both
validate-pr.ymlandvalidate-locksounds.ymlshould fail with these errors:Test plan
Validate PRworkflow failsValidate Locksounds Contentworkflow fails🤖 Generated with Claude Code