Skip to content

test: intentionally broken wrap submission [NAT-134]#58

Open
tallnato wants to merge 1 commit intomainfrom
paperclip/backelino/NAT-134
Open

test: intentionally broken wrap submission [NAT-134]#58
tallnato wants to merge 1 commit intomainfrom
paperclip/backelino/NAT-134

Conversation

@tallnato
Copy link
Copy Markdown
Member

Summary

  • Adds a test wrap entry (content/_wraps/test-broken-wrap/) with 5 intentional validation errors
  • Missing thumbnail field in frontmatter (required for wraps)
  • Wrong image format (.gif instead of .png)
  • Oversized image (1.1 MB > 1 MB limit)
  • Missing files field in frontmatter
  • Invalid tag not in content/tags.yaml

Expected CI Behavior

Both validate-pr.yml and validate-wraps.yml should fail.

Test plan

  • Local validation confirms all 5 errors detected
  • CI Validate PR workflow fails
  • CI Validate Wraps Content workflow fails
  • Results documented in PR comments

🤖 Generated with Claude Code

Adds a test wrap entry with intentional errors:
- Missing `thumbnail` field in frontmatter
- Wrong image format (.gif instead of .png)
- Oversized image (1.1 MB, limit is 1 MB)
- Missing `files` field in frontmatter
- Invalid tag not in tags.yaml

Co-Authored-By: Paperclip <noreply@paperclip.ing>
@github-actions github-actions bot added the wraps Changes to wraps content label Mar 27, 2026
@tallnato
Copy link
Copy Markdown
Member Author

CI Results (Expected Failures)

Both validation workflows failed as expected:

Check Status
Validate PR Failed
Validate Wraps Content Failed
Semantic PR Passed
Label Passed
Single Component Check Passed

Validation errors detected:

  1. wraps/test-broken-wrap.md: unknown tag "abstract"
  2. wraps/test-broken-wrap/broken-image.gif: invalid file type ".gif" (allowed: .png)
  3. wraps/test-broken-wrap/oversized-wrap.png: file too large (1.1 MB, max 1 MB)
  4. wraps/test-broken-wrap.md: missing required field "files"
  5. wraps/test-broken-wrap.md: missing required field "thumbnail"

Conclusion: Validation pipeline correctly catches all 5 intentional errors.

Copy link
Copy Markdown
Member Author

@tallnato tallnato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Approved ✓

This PR correctly implements the test case for CI validation.

Verified:

  • Both validate CI checks fail as expected — pipeline correctly catches the errors
  • single-component-check and label checks pass (correct — they validate different things)
  • 5 intentional errors present:
    1. Missing thumbnail field in frontmatter
    2. Missing files field in frontmatter
    3. .gif file (invalid format — only .png, .jpg, .jpeg, .webp, .svg allowed)
    4. Oversized .png image (>1 MB limit)
    5. Invalid tag abstract (not in tags.yaml)
  • File structure follows existing wrap conventions (*.md + */ asset directory)
  • No unintended changes outside the test content

LGTM. Validation pipeline is working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wraps Changes to wraps content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant