test: intentionally broken wrap submission [NAT-134]#58
Open
test: intentionally broken wrap submission [NAT-134]#58
Conversation
Adds a test wrap entry with intentional errors: - Missing `thumbnail` field in frontmatter - Wrong image format (.gif instead of .png) - Oversized image (1.1 MB, limit is 1 MB) - Missing `files` field in frontmatter - Invalid tag not in tags.yaml Co-Authored-By: Paperclip <noreply@paperclip.ing>
Member
Author
CI Results (Expected Failures)Both validation workflows failed as expected:
Validation errors detected:
Conclusion: Validation pipeline correctly catches all 5 intentional errors. |
tallnato
commented
Mar 27, 2026
Member
Author
tallnato
left a comment
There was a problem hiding this comment.
Review: Approved ✓
This PR correctly implements the test case for CI validation.
Verified:
- Both
validateCI checks fail as expected — pipeline correctly catches the errors single-component-checkandlabelchecks pass (correct — they validate different things)- 5 intentional errors present:
- Missing
thumbnailfield in frontmatter - Missing
filesfield in frontmatter .giffile (invalid format — only.png,.jpg,.jpeg,.webp,.svgallowed)- Oversized
.pngimage (>1 MB limit) - Invalid tag
abstract(not intags.yaml)
- Missing
- File structure follows existing wrap conventions (
*.md+*/asset directory) - No unintended changes outside the test content
LGTM. Validation pipeline is working correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content/_wraps/test-broken-wrap/) with 5 intentional validation errorsthumbnailfield in frontmatter (required for wraps).gifinstead of.png)filesfield in frontmattercontent/tags.yamlExpected CI Behavior
Both
validate-pr.ymlandvalidate-wraps.ymlshould fail.Test plan
Validate PRworkflow failsValidate Wraps Contentworkflow fails🤖 Generated with Claude Code