fix(web): the soundboard opens above the seated YouTube player - #2380
Merged
Merged
Conversation
Refs #2379 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The seated player is z-[56] so it clears the stage it sits in; the board was z-[55], matched to the popped-out stage and never weighed against the player. Its default spot is the top-left of the column the lounge seats the video in, so on the lounge every open landed under the player, grip included. The stacking rule (#483) puts a surface the rider pulled open above the player and below the drawers opened on top of it; the test now pins the board there. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
Author
|
Verified in the running app (worktree dev server + Vite, mixer zeroed on all four channels, a YouTube entry queued over the room's socket, lounge at 1297×1234):
The board opens at 288,128 (364×365) and the player is seated at 273,82 (672×378), so the two overlap on every open of the lounge — with the old layer only the fader's sliver showed under the video's bottom edge, which is the report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2379
The seated jukebox player is
z-[56]so it clears the stage it sits in. The soundboard's uncovered layer wasz-[55], matched to the popped-out stage in #877 and never weighed against the seated player, and its default spot is the top-left of the main column — exactly where the lounge seats the video. So opening the board while watching something put it behind the player, grip included: nothing to press, nothing to drag.stacking.test.tsalready states the rule (#483): RMF forbids our chrome over the player, never a surface the rider pulled open, and "anything the rider opens clears the player". The board is opened and closed by the rider, like the people sheet, so it belongs above the seated player and below the drawers a rider opens on top of it.Soundboard.svelte: uncovered layerz-[57]; thecovereddrop toz-30under modals is unchanged.stacking.test.ts: pins the board above the seated player and below the chat sheet, so the next renumbering notices.🤖 Generated with Claude Code