Skip to content

Switch to CC reviews v2#343

Open
Jarema wants to merge 1 commit intomainfrom
update-claude-workflow
Open

Switch to CC reviews v2#343
Jarema wants to merge 1 commit intomainfrom
update-claude-workflow

Conversation

@Jarema
Copy link
Member

@Jarema Jarema commented Mar 5, 2026

Signed-off-by: Tomasz Pietrek tomasz@synadia.com

Signed-off-by: Tomasz Pietrek <tomasz@synadia.com>
@Jarema Jarema requested review from piotrpio and wallyqs March 5, 2026 14:15
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Claude finished @Jarema's task in 34s —— View job


Code Review

  • Gather context
  • Read changed files
  • Review changes
  • Post findings

This PR upgrades the Claude Code workflow from v1 to v2 of the reusable workflow. The changes look correct and straightforward.

Summary of changes:

  • Bumps reusable workflow from @v1 to @v2
  • Adds gh_app_id and gh_app_private_key inputs — GitHub API access shifts to a GitHub App token instead of GITHUB_TOKEN
  • Drops explicit GITHUB_TOKEN permissions in favor of permissions: {} (least privilege), relying on the App token for all GitHub API calls
  • Adds checkout_mode: 'base' — checks out the base branch rather than the PR head, which is a security best practice for pull_request_target workflows to prevent untrusted code from running with elevated permissions

Security note: The use of pull_request_target with checkout_mode: 'base' is the correct and safe pattern here. Checking out the PR head in a pull_request_target context would be dangerous since that event has access to secrets; checking out only the base branch mitigates that risk.

No issues found. The changes are correct and improve the security posture of the workflow.

Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants