Fix news article title wrapping on narrow screens#288
Open
ChuanWeis wants to merge 1 commit into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow Medium article titles inside
#react-news-articleto wrap normally on narrow screens. This keeps the/newslisting card truncation innews-item.scssunchanged, so only the full article page title behavior changes.Issues Resolved
Fixes #163
Preview Links
A Netlify preview should be available from the pull request checks once the deploy is created.
Checklist
Validation performed:
git diff --check/newscard titles keep their truncation rulesnode_modules/.bin/sass --no-source-map themes/navhub-v2/static/css/sass/nav.scss themes/navhub-v2/static/css/nav.cssNote:
npm run sassuses Gulp 3 and does not run under the installed Node 22 runtime (primordials is not defined), so I used the installed Sass CLI to verify the same SCSS entrypoint.