Skip to content

INTERNAL: Extend bkey/eflag max length#816

Draft
namsic wants to merge 1 commit into
naver:developfrom
namsic:extend_bkey_eflag
Draft

INTERNAL: Extend bkey/eflag max length#816
namsic wants to merge 1 commit into
naver:developfrom
namsic:extend_bkey_eflag

Conversation

@namsic
Copy link
Copy Markdown
Collaborator

@namsic namsic commented Jan 8, 2025

🔗 Related Issue

  • jam2in/arcus-works#632

⌨️ What I did

  • MAX_BKEY_LENG, MAX_EFLAG_LENG 값을 증가시킵니다. (31 => 63)

@jhpark816 jhpark816 requested a review from ing-eoking January 8, 2025 05:28
@jhpark816
Copy link
Copy Markdown
Collaborator

jhpark816 commented Jan 8, 2025

@ing-eoking
MAX_BKEY_LENG, MAX_EFLAG_LENG 값을 증가시켰을 떄, 기존 구현에 문제가 될 만한 부분이 있는 지를 리뷰 바랍니다.

@namsic namsic force-pushed the extend_bkey_eflag branch from cebf4c4 to 15bff54 Compare January 8, 2025 05:39
@namsic
Copy link
Copy Markdown
Collaborator Author

namsic commented Jan 8, 2025

  • 문서 수정이 누락된 부분이 있어 추가하였습니다.

  • PR 반영되고 나면, EE에서는 아래 주석만 수정하면 될 것으로 보입니다.

struct cset_item_btree_unlink_noref {
  uint16_t  length;
  uint8_t   type;
  uint8_t   flags;
  hash_item *it; /* btree item */
  uint8_t   nbkey; /* 0 = 8B... */
  /* char bkey[MAX_BKEY_LENG];
   * MAX_BKEY_LENG = 31, defined in types.h.
   * The actual size of this item is sizeof(struct ...), rounded up to the
   * nearest multiple of 4.
   */
};

Copy link
Copy Markdown
Collaborator

@ing-eoking ing-eoking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LQ Detect의 LQ_QUERY_SIZE를 늘려야 할 것 같습니다.

#define LQ_QUERY_SIZE  (64*2+64)

// <longest bkey>..<longest bkey> efilter <offset> <count> delete

@namsic namsic force-pushed the extend_bkey_eflag branch from 15bff54 to b8df7eb Compare January 8, 2025 10:32
Copy link
Copy Markdown
Collaborator

@ing-eoking ing-eoking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Persistence 쪽 문자열 버퍼 크기 쪽도 수정해야 할 것 같습니다.

@namsic namsic force-pushed the extend_bkey_eflag branch from b8df7eb to e7c099e Compare January 10, 2025 02:26
@namsic namsic force-pushed the extend_bkey_eflag branch from e7c099e to 3d68197 Compare January 10, 2025 02:38
@ing-eoking ing-eoking requested a review from jhpark816 January 10, 2025 03:12
@namsic
Copy link
Copy Markdown
Collaborator Author

namsic commented Jan 13, 2025

현재 구현 기준 EE 버전에서 문제가 생길 소지가 있으므로 현재 PR 반영은 보류합니다. (이슈 코멘트 참고)

@namsic namsic marked this pull request as draft January 13, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants