Skip to content

INTERNAL: Revert flexible array members to 1-size array in cmdlogrec.h #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhpark816 merged 1 commit into from
May 19, 2026
Merged

INTERNAL: Revert flexible array members to 1-size array in cmdlogrec.h #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions engines/default/cmdlogrec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ typedef struct _IT_link_data {
uint64_t cas;
struct lrec_coll_meta meta;
} ptr;
char data[];
char data[1];
} ITLinkData;

typedef struct _IT_link_log {
Expand All @@ -150,7 +150,7 @@ typedef struct _IT_link_log {
/* Item Unlink Log Record */
typedef struct _IT_unlink_data {
uint16_t keylen; /* key length */
char data[];
char data[1];
} ITUnlinkData;

typedef struct _IT_unlink_log {
Expand All @@ -162,7 +162,7 @@ typedef struct _IT_unlink_log {
/* Item Flush Log Record */
typedef struct _IT_flush_data {
uint8_t nprefix; /* prefix length */
char data[];
char data[1];
} ITFlushData;

typedef struct _IT_flush_log {
Expand All @@ -181,7 +181,7 @@ typedef struct _IT_setattr_data {
uint8_t maxbkrlen; /* maxbkeyrange length */
uint8_t reserved_8[1];
int32_t mcnt; /* maximum element count */
char data[];
char data[1];
} ITSetAttrData;

typedef struct _IT_setattr_log {
Expand All @@ -196,7 +196,7 @@ typedef struct _snapshot_elem_data {
uint32_t nbytes;
uint8_t nekey; /* nbkey(btree), nfield(map) */
uint8_t neflag; /* neflag(btree) */
char data[];
char data[1];
} SnapshotElemData;

typedef struct _snapshot_elem_log {
Expand All @@ -223,7 +223,7 @@ typedef struct _List_elem_insert_data {
uint32_t vallen; /* value length */
uint32_t totcnt; /* total element count */
int32_t eindex; /* element index */
char data[];
char data[1];
} ListElemInsData;

typedef struct _List_elem_insert_log {
Expand All @@ -242,7 +242,7 @@ typedef struct _List_elem_delete_data {
uint32_t totcnt; /* total element count */
int32_t eindex; /* element index */
uint32_t delcnt; /* delete count */
char data[];
char data[1];
} ListElemDelData;

typedef struct _List_elem_delete_log {
Expand All @@ -257,7 +257,7 @@ typedef struct _Map_elem_insert_data {
uint8_t create; /* create flag */
uint8_t fldlen; /* field length */
uint32_t vallen; /* value length */
char data[];
char data[1];
} MapElemInsData;

typedef struct _Map_elem_insert_log {
Expand All @@ -273,7 +273,7 @@ typedef struct _Map_elem_delete_data {
uint16_t keylen; /* key length */
uint8_t drop; /* drop if empty */
uint8_t fldlen; /* field length */
char data[];
char data[1];
} MapElemDelData;

typedef struct _Map_elem_delete_log {
Expand All @@ -289,7 +289,7 @@ typedef struct _Set_elem_insert_data {
uint8_t create; /* create flag */
uint8_t reserved_8[1];
uint32_t vallen; /* value length */
char data[];
char data[1];
} SetElemInsData;

typedef struct _Set_elem_insert_log {
Expand All @@ -306,7 +306,7 @@ typedef struct _Set_elem_delete_data {
uint8_t drop; /* drop if empty */
uint8_t reserved_8[1];
uint32_t vallen; /* value length */
char data[];
char data[1];
} SetElemDelData;

typedef struct _Set_elem_delete_log {
Expand All @@ -324,7 +324,7 @@ typedef struct _Btree_elem_insert_data {
uint8_t neflag; /* eflag length */
uint8_t reserved_8[3];
uint32_t vallen; /* value length */
char data[];
char data[1];
} BtreeElemInsData;

typedef struct _Btree_elem_insert_log {
Expand All @@ -340,7 +340,7 @@ typedef struct _Btree_elem_delete_data {
uint16_t keylen; /* key length */
uint8_t drop; /* drop if empty */
uint8_t nbkey; /* bkey length */
char data[];
char data[1];
} BtreeElemDelData;

typedef struct _Btree_elem_delete_log {
Expand All @@ -365,7 +365,7 @@ typedef struct _Btree_elem_delete_logical_data {
uint8_t compop; /* compare operation */
uint32_t offset; /* element offset */
uint32_t reqcount; /* request count */
char data[];
char data[1];
} BtreeElemDelLgcData;

typedef struct _Btree_elem_delete_logical_log {
Expand Down
Loading