Skip to content

🏷️ refactor: add hash key and range key typing to methods#26

Open
StummeJ wants to merge 4 commits into
nayaverdier:mainfrom
fennelmarkets:key_typing
Open

🏷️ refactor: add hash key and range key typing to methods#26
StummeJ wants to merge 4 commits into
nayaverdier:mainfrom
fennelmarkets:key_typing

Conversation

@StummeJ

@StummeJ StummeJ commented Oct 23, 2024

Copy link
Copy Markdown

This adds in generic support so that we can get proper typing errors from pyright.

@codecov-commenter

codecov-commenter commented Oct 23, 2024

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (49b4a33) to head (144a5c5).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          669       687   +18     
  Branches       127       101   -26     
=========================================
+ Hits           669       687   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nayaverdier

Copy link
Copy Markdown
Owner

@StummeJ Thanks for the PR! And sorry for the delay. I want to make sure this doesn't break any static checkers like mypy for any users, by chance did you do any experimentation around that?

@StummeJ

StummeJ commented May 10, 2025

Copy link
Copy Markdown
Author

@nayaverdier it should be ok. It does pass the mypy checks on this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants