🏷️ refactor: add hash key and range key typing to methods#26
Open
StummeJ wants to merge 4 commits into
Open
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 669 687 +18
Branches 127 101 -26
=========================================
+ Hits 669 687 +18 ☔ View full report in Codecov by Sentry. |
Owner
|
@StummeJ Thanks for the PR! And sorry for the delay. I want to make sure this doesn't break any static checkers like mypy for any users, by chance did you do any experimentation around that? |
Author
|
@nayaverdier it should be ok. It does pass the mypy checks on this repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds in generic support so that we can get proper typing errors from pyright.