Minor initial setup cleanup#1
Open
bklarson wants to merge 76 commits into
Open
Conversation
Clean up the documentation a bit in a couple spots that caused some initial confusion. Fix the python code to not crash if the output/ directory doesn't exist.
bklarson
commented
Jun 12, 2020
| def write_file(data, filename): | ||
| ''' write bytes to file ''' | ||
| print(" writing %s bytes to %s" %(len(data), filename)) | ||
| os.makedirs(os.path.dirname(filename), exist_ok=True) |
Author
There was a problem hiding this comment.
This API requires Python 3.2. I'm not sure if you have a minimum supported version, or if this is ok? There are other solutions using a try/except block if we need to support < 3.2
Author
|
Thank you so much for creating this project and opening it up! I am looking to create a prosthetic after an unfortunate table saw accident late last year. My printer is pretty basic, so I might have some questions in the future about small tweaks that could help me out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up the documentation a bit in a couple spots that caused some
initial confusion. Fix the python code to not crash if the output/
directory doesn't exist.