Add custom Roborock component with MQTT reconnect fix (python-roborock 4.18.1) by Copilot · Pull Request #1 · ncecowboy/ha-roborock

Copilot · 2026-03-09T17:21:57Z

Original prompt

I'd like to work on a fix for the Home Assistant Core Integration, Roborock, to fix the MQTT timeout problems listed in issue home-assistant/core#164865. We'll need to copy the original integration into this repository, then work on fixing the MQTT issue.

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…oborock==4.18.1) Co-authored-by: ncecowboy <25276164+ncecowboy@users.noreply.github.com>

Copilot

Pull request overview

This PR adds a custom (HACS-installable) copy of Home Assistant’s Roborock integration, primarily to pick up python-roborock==4.18.1 which includes an MQTT reconnect/backoff fix to prevent re-auth/rate-limit loops when there are no active MQTT subscribers.

Changes:

Added a full custom_components/roborock integration copy (config flow, coordinators, entities, services, translations).
Bumped dependency pin to python-roborock==4.18.1 and added a component version for HACS.
Added HACS metadata (hacs.json) and updated README.md with problem/fix/install documentation.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
hacs.json	Adds HACS repository metadata for the custom integration.
README.md	Documents the MQTT reconnect problem, the upstream fix, and installation steps.
custom_components/roborock/init.py	Sets up the integration, device manager, runtime coordinators, and platform forwarding.
custom_components/roborock/binary_sensor.py	Adds Roborock binary sensor entities and descriptions.
custom_components/roborock/button.py	Adds Roborock button entities (consumables, routines, A01 devices).
custom_components/roborock/config_flow.py	Implements config/reauth flows and options flow.
custom_components/roborock/const.py	Defines integration constants, platforms, and polling intervals.
custom_components/roborock/coordinator.py	Adds update coordinators for multiple device families and trait refresh logic.
custom_components/roborock/diagnostics.py	Adds config entry diagnostics with redaction.
custom_components/roborock/entity.py	Adds common entity base classes and coordinated entity helpers.
custom_components/roborock/icons.json	Provides icon translations for entities and services.
custom_components/roborock/image.py	Adds map image entities backed by coordinator/home traits.
custom_components/roborock/manifest.json	Declares integration metadata and pins `python-roborock==4.18.1`.
custom_components/roborock/models.py	Defines integration data models (device info/state/map info).
custom_components/roborock/number.py	Adds numeric configuration entities (e.g., volume).
custom_components/roborock/quality_scale.yaml	Declares integration quality scale checklist/status.
custom_components/roborock/roborock_storage.py	Adds cache/map storage via HA `Store` and cleanup for legacy map storage.
custom_components/roborock/select.py	Adds select entities for multiple device types (V1/B01/A01) and map selection.
custom_components/roborock/sensor.py	Adds sensor entities for multiple device families and diagnostics.
custom_components/roborock/services.py	Registers entity services (maps, goto position, current position).
custom_components/roborock/services.yaml	Declares service UI metadata for the integration’s services.
custom_components/roborock/strings.json	Adds translations for config flow, entities, services, and exceptions.
custom_components/roborock/switch.py	Adds switch entities for V1 and A01 devices.
custom_components/roborock/time.py	Adds time entities (DND/off-peak timers).
custom_components/roborock/vacuum.py	Adds vacuum entities and vacuum-specific services (segments, maps, goto position).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-09T17:37:08Z

@@ -0,0 +1,46 @@
+"""Support for the Airzone diagnostics."""


The docstring references “Airzone” instead of Roborock, which is misleading for diagnostics/debugging. Please update it to reflect the Roborock integration.

Copilot · 2026-03-09T17:37:09Z

+                    self.properties_api.clean_summary,
+                    self.properties_api.dnd,
+                    self.properties_api.dust_collection_mode,
+                    self.properties_api.wash_towel_mode,
+                    self.properties_api.smart_wash_params,
+                    self.properties_api.sound_volume,
+                    self.properties_api.child_lock,
+                    self.properties_api.dust_collection_mode,
+                    self.properties_api.flow_led_status,
+                    self.properties_api.valley_electricity_timer,


dust_collection_mode appears twice in the trait refresh list, which causes redundant refresh calls and extra load. Remove the duplicate entry so each trait is refreshed only once per update cycle.

Copilot · 2026-03-09T17:37:09Z

+        # This currenltly only supports the WetDryVac protocols
+        self.request_protocols: list[RoborockDyadDataProtocol] = [


Typo in comment (“currenltly”). Please correct to “currently” to keep comments professional and searchable.

Copilot · 2026-03-09T17:37:09Z

+  fields:
+    x:
+      example: 27500
+      required: true
+      selector:
+        text:
+          type: number
+    y:
+      example: 32000
+      required: true
+      selector:
+        text:
+          type: number


The service YAML declares x/y with a text selector even though the service schema coerces them to int. This mismatch can lead to a confusing UI and invalid input handling. Use a number selector (optionally with min/max/step) to reflect the expected integer coordinates.

Copilot · 2026-03-09T17:37:10Z

+    comment: |
+      The docs describe controlling the vacuum, though does not describe more
+      interesting potential integrations with the homoe assistant ecosystem.
+  dynamic-devices: todo


Typo in comment (“homoe assistant”). Please correct to “Home Assistant” to avoid spelling mistakes in repository docs/metadata.

Copilot · 2026-03-09T17:37:10Z

+    "no_user_agreement": {
+      "message": "You have not valid user agreement. Open your Roborock app and accept the agreement."
+    },


The no_user_agreement exception message is grammatically incorrect (“You have not valid…”), which will be shown to users. Please update it to a correct phrasing (e.g., “You do not have a valid user agreement …”).

ncecowboy · 2026-03-09T17:52:48Z

@copilot apply changes based on the comments in this thread

…er selector, grammar fix Co-authored-by: ncecowboy <25276164+ncecowboy@users.noreply.github.com>

Copilot · 2026-03-09T17:54:33Z

@copilot apply changes based on the comments in this thread

Applied all 6 review comments in commit fc04648:

diagnostics.py: Fixed docstring "Airzone" → "Roborock"
coordinator.py: Removed duplicate dust_collection_mode entry from trait refresh list
coordinator.py: Fixed typo "currenltly" → "currently"
services.yaml: Changed x/y selectors from text to number (with min: 0, max: 65000, step: 1, mode: box)
quality_scale.yaml: Fixed typo "homoe assistant" → "Home Assistant"
strings.json: Fixed grammar "You have not valid user agreement" → "You do not have a valid user agreement"

Initial plan

36416bc

Copilot AI assigned Copilot and ncecowboy Mar 9, 2026

Copilot started work on behalf of ncecowboy March 9, 2026 17:22 View session

Copy HA Roborock integration and fix MQTT timeout issue (use python-r…

422e579

…oborock==4.18.1) Co-authored-by: ncecowboy <25276164+ncecowboy@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix MQTT timeout problems in Roborock integration~~ Add custom Roborock component with MQTT reconnect fix (python-roborock 4.18.1) Mar 9, 2026

Copilot finished work on behalf of ncecowboy March 9, 2026 17:28

ncecowboy marked this pull request as ready for review March 9, 2026 17:29

Copilot AI review requested due to automatic review settings March 9, 2026 17:29

Copilot started reviewing on behalf of ncecowboy March 9, 2026 17:29 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

Copilot started work on behalf of ncecowboy March 9, 2026 17:52 View session

Fix review comments: Roborock docstring, duplicate trait, typos, numb…

fc04648

…er selector, grammar fix Co-authored-by: ncecowboy <25276164+ncecowboy@users.noreply.github.com>

Copilot finished work on behalf of ncecowboy March 9, 2026 17:55

ncecowboy merged commit 842faf1 into main Mar 9, 2026

ncecowboy deleted the copilot/fix-mqtt-timeout-issues branch March 9, 2026 17:57

Navigation Menu

Add custom Roborock component with MQTT reconnect fix (python-roborock 4.18.1) - #1

Add custom Roborock component with MQTT reconnect fix (python-roborock 4.18.1)#1
ncecowboy merged 3 commits into
mainfrom
copilot/fix-mqtt-timeout-issues

Copilot AI commented Mar 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

ncecowboy commented Mar 9, 2026

Uh oh!

Copilot AI commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		# This currenltly only supports the WetDryVac protocols
		self.request_protocols: list[RoborockDyadDataProtocol] = [

Conversation

Copilot AI commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

ncecowboy commented Mar 9, 2026

Uh oh!

Copilot AI commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 9, 2026 •

edited

Loading