Skip to content

sketches vs parts #38

Description

@wjcarpenter

I will soon send you a PR that introduces a fragment that allows inline color changes in a label (and some other changes). However, in order to implement that, I had to made a very significant conceptual and structural change in the code base. Instead of building up a hierarchy of Sketches and extruding a Part at the top of things, I changed to extruding a Part for each fragment and passing up build123d Compounds.

That turned to to make several things simpler (at least concerning inline color changes), but it represented a massive, massive code churn. I'm a very strong believer in contributing changes upstream, but, due to the massive churn, I wouldn't blame you if you didn't want to take the PR or even take the time to analyze it. In a nutshell, you can decide what you want to do, and no hard feelings from me if you just close the PR with no action. (I think I have manually incorporated all of the changes from your recent commits.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions