Avoid having large requests go through Redis - #252
Open
MichaelRipa wants to merge 1 commit into
Open
Conversation
…or if request too large
MichaelRipa
marked this pull request as ready for review
April 24, 2026 15:41
Member
Author
|
Benchmarks on dev stack: With tmp file routing (starting at 16 MB): Without tmp file routing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a known issue of Redis having an implicit upperbound of 512 MB key/values, and of Redis being slow with large payloads. Before this fix, the API would throw a cryptic error if a request exceeded said upperbound. We now enforce an explicit upperbound, and route larger requests from api to queue by dumping to
/tmpinstead of through Redis.Introduced Environment variables
NDIF_QUEUE_TEMP_FILE_THRESHOLD: Determines when to route requests to/tmp(rather then redis, defaults to 16MB)NDIF_MAX_REQUEST_SIZE: Maximum content-length of request (defaults to 1GB)