Pass-Through Simfils Auto-Wildcard, Any-Mode Feature and Fix Tests#89
Merged
MisterGC merged 4 commits intosimfil-remove-conanfrom Apr 8, 2025
Merged
Conversation
johannes-wolf
force-pushed
the
simfil-query-enumerations-as-constants
branch
from
86ce211 to
89f429e
Compare
johannes-wolf
force-pushed
the
simfil-query-enumerations-as-constants
branch
from
89f429e to
a76a7b8
Compare
johannes-wolf
force-pushed
the
simfil-query-enumerations-as-constants
branch
3 times, most recently
from
9e80f5e to
0efd21b
Compare
johannes-wolf
force-pushed
the
simfil-query-enumerations-as-constants
branch
from
0efd21b to
14a07f1
Compare
|
Minimum allowed line rate is |
MisterGC
reviewed
Apr 7, 2025
Contributor
MisterGC
left a comment
MisterGC
left a comment
There was a problem hiding this comment.
PR title and branch name don't fit to the code changes or do I miss something - please update them on demand and provide a short description about what this PR intends to change.
johannes-wolf
changed the title
johannes-wolf
changed the title
MisterGC
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use simfils native auto-wildcard and any-mode feature flags when evaluating expressions.