docs: require every CVM port (incl. migration :8079) bound to a dedicated IP#3458
docs: require every CVM port (incl. migration :8079) bound to a dedicated IP#3458barakeinav1 wants to merge 3 commits into
:8079) bound to a dedicated IP#3458Conversation
…ated IP The multi-node guide listed only :80/:8080/:24567 for per-CVM host_address binding, omitting the migration port :8079 (which defaults to 0.0.0.0:8079 in the single-node template). A wildcard 0.0.0.0 bind on any port blocks other CVMs from binding it on their own IP, so the first CVM to boot wins and the others crash-loop. Add :8079 to the list and warn against 0.0.0.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the multi-CVM deployment guide to prevent port-forward conflicts when running multiple MPC CVMs on a single host by requiring per-CVM port forwards to bind to the CVM’s dedicated host IP (not 0.0.0.0), including the migration port.
Changes:
- Adds
:8079(migration) to the list of public ports that must be bound to the CVM’s dedicated IP. - Adds an explicit warning describing the wildcard-bind failure mode (
0.0.0.0:<port>preventing other CVMs from binding the same port on their own IPs).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| For **every public port forward** (`:80`, `:8080`, `:24567`, **and the | ||
| migration port `:8079`**), set the **host address** to that CVM's | ||
| assigned IP — never `0.0.0.0`. The dstack-vmm web UI exposes this field | ||
| next to host port / VM port at CVM-creation time. |
There was a problem hiding this comment.
Fixed in 45eaa88 — added :8079 to the Step 1 Plan-IPs table (and the firewall bullet, architecture diagram, and key-properties bullet) so the whole doc is consistent.
Pull request overviewDocs-only fix to Changes:
Reviewed changesPer-file summary
I cross-checked against FindingsNon-blocking (consistency follow-ups inside the same file): The change only updates Step 2. The rest of the document still lists the multi-node port set as
Without these, an operator reading Step 1 and planning IP allocations from the table would still miss ✅ Approved — the change itself is correct and lands the key warning. The follow-ups above would tighten internal consistency but aren't blocking. |
…guide Address review: the prerequisites firewall bullet, the architecture diagram, the key-properties bullet, and the Step 1 Plan-IPs table all still listed :80/:8080/:24567 and omitted the migration port :8079, contradicting the new Step 2 guidance. Add :8079 to all four so an operator planning IP allocations from the table doesn't miss it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Addressed all four consistency follow-ups in 45eaa88: the prerequisites firewall bullet, the architecture diagram, the key-properties bullet, and the Step 1 Plan-IPs table now all include |
Closes #3457