Skip to content

796: adds two new engagement types to NGO engagement #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarrellRoberts wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

796: adds two new engagement types to NGO engagement #923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d698c8e
adds new agentengagement types
DarrellRoberts Aug 7, 2026
9ed6d29
Merge branch 'develop' into darrell/feat/new-engagement-statuses
DarrellRoberts Aug 11, 2026
037a500
adds new icons & color backgrounds
DarrellRoberts Aug 11, 2026
0adae6c
corrects constant bug
DarrellRoberts Aug 11, 2026
8c6d479
Merge branch 'develop' into darrell/feat/new-engagement-statuses
arturasmckwcz Aug 26, 2026
26a494f
Merge branch 'develop' into darrell/feat/new-engagement-statuses
arturasmckwcz Aug 26, 2026
a126cd9
Merge branch 'develop' into darrell/feat/new-engagement-statuses
arturasmckwcz Aug 27, 2026
f36e1b5
resolves merge conflicts
DarrellRoberts Aug 27, 2026
d6025db
aligns statusMaps in dashboard/common
DarrellRoberts Aug 27, 2026
a890f18
Merge branch 'darrell/feat/new-engagement-statuses' of github.com:nee…
DarrellRoberts Aug 27, 2026
59b970c
Merge branch 'develop' into darrell/feat/new-engagement-statuses
arturasmckwcz Aug 31, 2026
7d5c296
Merge branch 'develop' into darrell/feat/new-engagement-statuses
need4deed Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/components/Dashboard/Profile/common/statusMaps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ import {
CalendarBlankIcon,
CalendarXIcon,
ChartLineIcon,
ChatsCircleIcon,
CheckCircleIcon,
HandPalmIcon,
HourglassIcon,
PhoneDisconnectIcon,
PhoneXIcon,
ProhibitInsetIcon,
QuestionIcon,
Expand Down Expand Up @@ -99,6 +101,8 @@ export const statusColorMap: Record<StatusValue, string> = {
[AgentEngagementStatusType.ACTIVE, "var(--color-green-100)"],
[AgentEngagementStatusType.INACTIVE, "var(--color-grey-50)"],
[AgentEngagementStatusType.UNRESPONSIVE, "var(--color-grey-50)"],
[AgentEngagementStatusType.INCONTACT, "var(--color-green-500)"],
[AgentEngagementStatusType.TRIED_TO_CONTACT, "var(--color-grey-200)"],
]),
...manualStatusColorMap,
};
Expand Down Expand Up @@ -147,6 +151,8 @@ export const statusIconMap: Record<StatusValue, IconComponent> = {
[AgentEngagementStatusType.ACTIVE, ChartLineIcon],
[AgentEngagementStatusType.INACTIVE, StopCircleIcon],
[AgentEngagementStatusType.UNRESPONSIVE, PhoneXIcon],
[AgentEngagementStatusType.INCONTACT, ChatsCircleIcon],
[AgentEngagementStatusType.TRIED_TO_CONTACT, PhoneDisconnectIcon],
]),
...manualStatusIconMap,
};
6 changes: 3 additions & 3 deletions src/components/Dashboard/common/statusMaps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ export const statusColorMap: Record<StatusValue, string> = {
[AgentEngagementStatusType.ACTIVE]: "var(--color-green-100)",
[AgentEngagementStatusType.UNRESPONSIVE]: "var(--color-grey-50)",
[AgentEngagementStatusType.INACTIVE]: "var(--color-grey-50)",
[AgentEngagementStatusType.NEW]: "var(--color-green-100)",
[AgentEngagementStatusType.INCONTACT]: "var(--color-green-100)",
[AgentEngagementStatusType.TRIED_TO_CONTACT]: "var(--color-green-100)",
[AgentEngagementStatusType.NEW]: "var(--color-violet-100)",
[AgentEngagementStatusType.INCONTACT]: "var(--color-green-500)",

@arturasmckwcz arturasmckwcz Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: statusIconMap further down in this file was left unchanged for INCONTACT/TRIED_TO_CONTACT (still SparkleIcon, same as NEW), even though this diff gives them distinct colors here, and the sibling Dashboard/Profile/common/statusMaps.ts gives them distinct icons (ChatsCircleIcon/PhoneDisconnectIcon).

Failure scenario: Any future caller of Dashboard/common/StatusBadge.tsx for engagement status will render the new colors paired with the wrong, stale icon, inconsistent with how the same statuses render on the agent profile page. Currently dormant because AgentCard.tsx only feeds volunteerSearch (not engagementStatus) into this specific StatusBadge, so it won't visibly break until that column is wired up — but the next person to consume this map has no reason to suspect the inconsistency.

[AgentEngagementStatusType.TRIED_TO_CONTACT]: "var(--color-grey-200)",
[AgentVolunteerSearchType.NOT_NEEDED]: "var(--color-grey-50)",
[AgentVolunteerSearchType.VOLUNTEERS_FOUND]: "var(--color-green-100)",
[AgentVolunteerSearchType.SEARCHING]: "var(--color-red-50)",
Expand Down
Loading