feat: volunteer self-registration with email confirmation by nadavosa · Pull Request #955 · need4deed-org/fe

nadavosa · 2026-08-28T11:20:37Z

Description

Adds a public "Become a volunteer" registration page, mirroring the existing NGO/agent registration screen (/register/agent) but for volunteers. Same account fields (first name, last name, email, password, confirm password, phone, consent), headline "Become a volunteer" instead of "Register your organisation".

No backend or SDK change was needed:

POST /user already accepts role: UserRole.VOLUNTEER and self-registers it freely (its pre-handler comment: "Volunteers and users self-register freely", unlike AGENT which requires a matching org email domain).
It already sends the verification email for any role.
verify-email/[token]/page.tsx already redirects any non-"agent" role straight to /dashboard after verification, so no extra profile-completion step is needed for volunteers.
The consent checkboxes' linked pages (Privacy, Need4Deed Guidelines, Voluntary Participation Agreement) already address volunteers directly in their copy, so the same three links apply unchanged.

Related Issues

Closes #954

Changes

New route /register/volunteer → VolunteerRegistration component, POSTs role: UserRole.VOLUNTEER.
Generalized AccountStep and validateStep (under AgentRegistration/) with an optional namespace param (defaults to "agentRegistration", so the existing agent flow is unchanged) instead of duplicating the ~150 lines of identical field markup/validation for a second flow.
Reused AgentRegistration's styled.ts primitives and added a volunteerRegistration i18n namespace (en/de) for the copy that does differ (headline, subtitle, success screen).

Verification

tsc --noEmit and yarn lint pass.
Ran the dev server and confirmed /en/register/volunteer renders the headline, all fields, and the consent links correctly; verified client-side validation triggers on empty submit. Did not exercise the live POST /user call (no backend running locally), that endpoint itself is unchanged.

Checklist

WITHIN THE SCOPE OF AN ISSUE; No unnecessary files included
Tests added/updated
Documentation updated
CI passes

Mirrors the NGO/agent registration screen but for volunteers, headline "Become a volunteer" instead of "Register your organisation". Same account fields, POSTs role: UserRole.VOLUNTEER to the existing POST /user endpoint, which already self-registers volunteers freely and sends the verification email (no BE/SDK change needed). Generalizes AccountStep/validateStep with a translation-namespace parameter (default unchanged, so the agent flow is unaffected) instead of duplicating the step markup and validation logic.

arturasmckwcz · 2026-08-29T10:26:04Z

Review findings

1. Consent checkbox still shows agent-only legal copy to volunteers (src/components/AgentRegistration/steps/AccountStep.tsx:96)

AccountStep was generalized with a namespace prop and every other label switched to t(\${namespace}...`), but the consent line's guidelines link still uses the non-namespaced homepage.footer.legal.guidelineskey andSubpage.RAC_GUIDELINES— both written for accommodation centers. A volunteer signing up at/register/volunteer` has to check a required legal-consent box reading "...RAC Guidelines..." linking to content addressed to accommodation centers ("request matching", "volunteer screening"), not to volunteers.

2. PageWrapper override duplicated instead of shared (src/components/VolunteerRegistration/VolunteerRegistration.tsx:31)

The min-height: 0; flex: 1 override (and its explanatory comment, which literally says "see the same override in AgentRegistration.tsx") is copy-pasted verbatim rather than extracted into the shared styled.ts next to Wrapper/Card. A future fix to how PageLayout composes with Wrapper now has to be applied in two places and can silently drift.

3. No dedupe check against an existing Volunteer/Person by email (src/components/VolunteerRegistration/VolunteerRegistration.tsx:57)

handleSubmit POSTs straight to /user with no person.id and no prior lookup. On the backend, POST /user (src/server/routes/user.ts ~lines 318-350) only looks up an existing Person when person.id is explicitly passed — otherwise it unconditionally creates a new one, even when a Person with that exact email already exists (e.g. via an existing Volunteer row from the legacy public form). Someone who already submitted the "Become a Volunteer" form and now self-registers here with the same email ends up with a second, disconnected Person/User pair instead of being linked to their existing volunteer profile — silently, with no error surfaced to them or a coordinator.

This third one is a pre-existing backend gap, not something this PR introduces, so I filed it as a standalone follow-up rather than blocking this PR on it: need4deed-org/be#923 (tracked under the epic need4deed-org/be#922).

DarrellRoberts · 2026-08-31T08:30:47Z

+import { AccountRegistrationData, defaultAccountRegistrationData } from "@/components/AgentRegistration/types";
+import Link from "next/link";
+
+const NAMESPACE = "volunteerRegistration";


this seems pointless to me as you're not really reusing a component, just duplicating it. Also in the AgentRegistration component you're using the raw string instead
e.g.

<PageTitle>{t("agentRegistration.title")}</PageTitle>

compared to

<PageTitle>{t(`${NAMESPACE}.title`)}</PageTitle>

DarrellRoberts · 2026-08-31T08:51:02Z

+  const [submitError, setSubmitError] = useState<string | null>(null);
+  const [isSubmitting, setIsSubmitting] = useState(false);
+  const [isSuccess, setIsSuccess] = useState(false);
+


with our legacy BecomeVolunteer form found on components/forms/BecomeVolunteer/BecomeVolunteer.tsx, we used tanstack useForm hook which reduced the need for all of these useState

DarrellRoberts · 2026-08-31T08:59:37Z

+    } finally {
+      setIsSubmitting(false);
+    }
+  };


line 70-99 would be cleaner as a custom hook. We do have a custom usePostRequest hook but it seems a bit outdated (uses fetch API over axios)

DarrellRoberts · 2026-08-31T09:05:03Z

+  min-height: 0;
+  flex: 1;
+`;
+


if you move this PageWrapper to and export this from @/components/AgentRegistration/styled (like the other styled components) then you don't have to declare it twice such as here & in the AgentRegistration.tsx component

DarrellRoberts

Just a few code-cleaniless points from me.

Also I imagine we want this component to also be what the "Join as a volunteer" to link to as well?

This links to the legacy BecomeVolunteer form and sits on route: /[lang]/forms/volunteer

nadavosa mentioned this pull request Aug 28, 2026

feat: volunteer profile completion after email confirmation #956

Open

need4deed requested a review from DarrellRoberts August 28, 2026 11:32

Merge branch 'develop' into nadavosa/954-volunteer-registration

090a918

This was referenced Aug 29, 2026

fix: POST /user must link to an existing Person by email instead of creating a duplicate need4deed-org/be#923

Open

Epic: invite existing volunteers to register as users (role: volunteer) need4deed-org/be#922

Open

DarrellRoberts reviewed Aug 31, 2026

View reviewed changes

arturasmckwcz assigned nadavosa Aug 31, 2026

Merge branch 'develop' into nadavosa/954-volunteer-registration

1beeef0

Navigation Menu

Uh oh!

feat: volunteer self-registration with email confirmation - #955

feat: volunteer self-registration with email confirmation#955
nadavosa wants to merge 3 commits into
developfrom
nadavosa/954-volunteer-registration

nadavosa commented Aug 28, 2026

Uh oh!

arturasmckwcz commented Aug 29, 2026

Uh oh!

DarrellRoberts Aug 31, 2026 •

edited

Loading

Uh oh!

DarrellRoberts Aug 31, 2026

Uh oh!

DarrellRoberts Aug 31, 2026

Uh oh!

DarrellRoberts Aug 31, 2026 •

edited

Loading

Uh oh!

DarrellRoberts left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nadavosa commented Aug 28, 2026

Description

Related Issues

Changes

Verification

Checklist

Uh oh!

arturasmckwcz commented Aug 29, 2026

Review findings

Uh oh!

DarrellRoberts Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DarrellRoberts Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

DarrellRoberts Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

DarrellRoberts Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DarrellRoberts left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DarrellRoberts Aug 31, 2026 •

edited

Loading

DarrellRoberts Aug 31, 2026 •

edited

Loading