Updated resources for v3 release#428
Open
nefarius wants to merge 8 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughReplaces beta wording and experimental v3 links with stable v3 documentation links, updates the DevicesPage troubleshooting hyperlink and removes a leading BOM, and introduces renamed installer dialog/actions and a .NET 9 runtime prerequisite with associated checks and messaging. ChangesDocumentation & Installer
Sequence Diagram(s)sequenceDiagram
participant InstallScript as InstallScript
participant MSI_UI as OnlineDocumentationDialog
participant Model as OnlineDocumentationDialogModel
participant OS as Browser (Process)
InstallScript->>MSI_UI: Launch OnlineDocumentationDialog
MSI_UI->>Model: Init() / set DataContext
User->>MSI_UI: Click "Open documentation" link
MSI_UI->>Model: Hyperlink navigation handler
Model->>OS: Process.Start(InstallScript.OnlineDocumentationUrl)
OS-->>Model: (browser opens / error)
User->>MSI_UI: Click Next
MSI_UI->>Model: GoNext()
Model->>InstallScript: Shell.GoNext()
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Contributor
|
Note Docstrings generation - SUCCESS |
Docstrings generation was requested by @nefarius. The following files were modified: * `setup/Dialogs/OnlineDocumentationDialog.xaml.cs` * `setup/InstallScript.cs` These file types are not supported: * `ControlApp/Views/Pages/DevicesPage.xaml` * `README.md` * `setup/Dialogs/OnlineDocumentationDialog.xaml`
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
setup/Dialogs/OnlineDocumentationDialog.xaml.cs (1)
28-33: Consider declaring the field before its usage.The
_modelfield is declared on line 33 after being used inInit()on line 30. While this is valid C#, conventional ordering places field declarations before methods for better readability.♻️ Optional reordering
public partial class OnlineDocumentationDialog : WpfDialog, IWpfDialog { + private OnlineDocumentationDialogModel _model; + /// <summary> /// Initializes a new instance of OnlineDocumentationDialog and initializes its WPF UI components. /// </summary> public OnlineDocumentationDialog() { InitializeComponent(); } /// ... public void Init() { DataContext = _model = new OnlineDocumentationDialogModel { Host = ManagedFormHost }; } - private OnlineDocumentationDialogModel _model;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@setup/Dialogs/OnlineDocumentationDialog.xaml.cs` around lines 28 - 33, The _model field is declared after it’s used in Init(), which hurts readability; move the field declaration for _model (type OnlineDocumentationDialogModel) above the Init() method (so it's declared before DataContext/_model assignment) or alternatively initialize it inline at declaration to ensure the field appears before methods like Init() that reference it.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@setup/InstallScript.cs`:
- Around line 374-380: The XML documentation for the donation page opener
contains a malformed/unclosed <summary> tag; locate the docblock immediately
above the method that opens the donations page (the comment starting "Open
donations page in default browser." / "Opens the donation web page..." in
InstallScript.cs) and fix the XML by removing the extra opening <summary> or
closing it properly so there is exactly one well-formed <summary> ... </summary>
element, ensure the <param> and <returns> tags remain intact and valid, and run
the compiler or XML doc check to verify the warning is gone.
- Around line 351-357: The XML doc for the method that opens the product's
online documentation has a malformed/unclosed <summary> tag; edit the
documentation above that method (the comment block describing "Open online
documentation in default browser" / "Opens the product's online documentation
URL in the user's default browser") to remove the stray duplicate <summary>
start tag and ensure there is a single properly opened and closed <summary>
section (i.e., one <summary> ... </summary>) and keep the <param> and <returns>
tags unchanged so the XML documentation is well-formed for the method that
launches the docs.
- Around line 301-307: The XML doc for the method that downloads and installs
BthPS3 contains an unclosed <summary> tag (the first summary before the one
describing downloading metadata); close the initial <summary> properly (or
remove the duplicate) so there is a single well-formed <summary> section for the
method that references the session parameter and return information; update the
XML comment surrounding the "Download and install BthPS3" description to be one
coherent <summary> block and ensure all XML tags are properly closed.
---
Nitpick comments:
In `@setup/Dialogs/OnlineDocumentationDialog.xaml.cs`:
- Around line 28-33: The _model field is declared after it’s used in Init(),
which hurts readability; move the field declaration for _model (type
OnlineDocumentationDialogModel) above the Init() method (so it's declared before
DataContext/_model assignment) or alternatively initialize it inline at
declaration to ensure the field appears before methods like Init() that
reference it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 47dff494-d170-4802-a124-3f99bf74c764
📒 Files selected for processing (2)
setup/Dialogs/OnlineDocumentationDialog.xaml.cssetup/InstallScript.cs
Keep _model field before constructor; combine with XML docs from incoming branch. Made-with: Cursor
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@setup/InstallScript.cs`:
- Around line 246-260: The runtime directory name parsing fails for preview
names like "9.0.0-preview..."; update the check in the block that iterates
Directory.GetDirectories(runtimeDir) (using Path.GetFileName(versionDir)) to
normalize dirName before Version.TryParse: strip any "-" and everything after
(or extract the leading numeric semver token) to get a numeric version string,
then call Version.TryParse on that normalized string and evaluate
installedVersion.Major >= 9; ensure you still handle parse failures gracefully
(skip non-parseable names) and keep the existing session.Log and return
ActionResult.Success behavior when a qualifying runtime is found.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 27707b10-ecd6-4124-a056-2267a96718b8
📒 Files selected for processing (1)
setup/InstallScript.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Documentation
New Features
Chores