This repository was archived by the owner on Apr 6, 2020. It is now read-only.
fix link to menubar in package.json, add .nvmrc#2
Open
sibsfinx wants to merge 1 commit intonek023:masterfrom
Open
fix link to menubar in package.json, add .nvmrc#2sibsfinx wants to merge 1 commit intonek023:masterfrom
sibsfinx wants to merge 1 commit intonek023:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@questbeat
Thanks for this great app!
Tried to build by myself so did a minor fix.
Menubar package doesn't install without 'git+https' (npm v2.11.3).
Not sure about minimum node version, but I've got build failing with 0.10.32 and working with v0.12.7.