Conversation
Change Events.preCo from a plain Prop to a structure with two fields: - wellTyped: the existing well-typedness condition on co pairs - total: co is a total order on same-location writes Update all wellformed.co instances in Litmus.lean to prove both fields.
- wellformed.rf: extend to a structure with wellTyped (existing conditions) and unique (each read has at most one rf source) - Events.preCo: extend to a structure with wellTyped (existing conditions) and total (co is a total order on same-location writes) - CandidateExecution: remove fr as a settable field; define it as a transparent @[simp] def so theorems can unfold it - Litmus.lean: update all rfInst and preco proofs for the new structures - Theorems.lean: prove rf_fr_subset_co (rf;fr⊆co via rf uniqueness)
co_acyclic: co is acyclic, following from wellformed.co's irrefl and trans via the existing strictPartialOrderImpliesAcyclic lemma. fr_co_subset_fr: fr;co ⊆ fr — if (r,w)∈fr and (w,w')∈co then (r,w')∈fr. Proof unfolds fr, applies co transitivity, and repacks.
- Add CoWR condition to CandidateExecution: a read cannot observe a write older than the most recent same-location po-predecessor, needed to prove LKMM coherence from TSO acyclicity - Instantiate coWR for all three litmus tests (SB, MP, LB) - Fix two bugs in Macro.lean: rfe was X.fr instead of X.rf, and ext was Rel.internal instead of Rel.external - Add X86WeakerThanLKMM.lean with theorem statement (proof pending) - Fix tsoWeakerThanSc.lean imports and remove broken ConcreteExecution Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.