Fix DependencyUtils failing to infer artifact classifier under some circumstances#257
Merged
Technici4n merged 1 commit intoJun 5, 2025
Conversation
|
Technici4n
approved these changes
Jun 5, 2025
Technici4n
left a comment
Technici4n
left a comment
Member
There was a problem hiding this comment.
LGTM. This is also gets rid of the internal API usage, which is good!
|
🚀 This PR has been released as ModDevGradle version |
Collaborator
Oh wow I didn't even notice that this gets rid of internal, that is indeed good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under some circumstances
DependencyUtilscan fail to infer the artifact classifier for processed dependencies, which causes thecreateMinecraftArtifactstask to fail during source recompilation due to Minecraft's dependencies not resolving correctly.The specific case in which I encountered this is when using an Artifact Transformer; here I have a minimal reproduction of this case using the MDK and a dummy artifact transform plugin that applies a no-op to jar dependencies.
I tested that minimal reproduction against this fix and it succeeded to build; in addition the contents of
nfrt_artifact_manifest.propertieswere identical to those produced with no artifact transform (after sorting the entries), as expected.I don't know if this fix will work in every case, but I expect that it should at least work in the vast majority of cases.