Skip to content

Downgrade "Failed to parse..." message to info level #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Technici4n merged 1 commit into from
Mar 22, 2026
Merged

Downgrade "Failed to parse..." message to info level #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/main/java/net/neoforged/moddevgradle/internal/utils/VersionCapabilitiesInternal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public static VersionCapabilitiesInternal latest() {
public static VersionCapabilitiesInternal ofMinecraftVersion(String minecraftVersion) {
var versionIndex = MinecraftVersionList.VERSIONS.indexOf(minecraftVersion);
if (versionIndex == -1) {
LOG.lifecycle("Minecraft Version {} is unknown. Assuming latest capabilities.", versionIndex);
LOG.info("Minecraft Version {} is unknown. Assuming latest capabilities.", versionIndex);
return LATEST.withMinecraftVersion(minecraftVersion);
}

Expand Down Expand Up @@ -140,12 +140,12 @@ private static String neoForgeVersionToMinecraftVersion(String version) {
public static VersionCapabilitiesInternal ofNeoForgeVersion(String version) {
var mcVersion = neoForgeVersionToMinecraftVersion(version);
if (mcVersion == null) {
LOG.lifecycle("Failed to parse MC version from NeoForge version {}. Using capabilities of latest known Minecraft version {}.", version, LATEST.minecraftVersion());
LOG.info("Failed to parse MC version from NeoForge version {}. Using capabilities of latest known Minecraft version {}.", version, LATEST.minecraftVersion());
return LATEST;
}
var index = MinecraftVersionList.VERSIONS.indexOf(mcVersion);
if (index == -1) {
LOG.lifecycle("Parsed unknown MC version {} from NeoForge version {}. Using capabilities of latest known Minecraft version {} with an updated Minecraft version.", mcVersion, version, LATEST.minecraftVersion());
LOG.info("Parsed unknown MC version {} from NeoForge version {}. Using capabilities of latest known Minecraft version {} with an updated Minecraft version.", mcVersion, version, LATEST.minecraftVersion());
return LATEST.withMinecraftVersion(mcVersion);
}
return ofVersionIndex(index);
Expand All @@ -167,12 +167,12 @@ public static VersionCapabilitiesInternal ofNeoFormVersion(String version) {
if (index == -1) {
var mcVersion = neoFormVersionToMinecraftVersion(version);
if (mcVersion == null) {
LOG.lifecycle("Failed to parse MC version from NeoForm version {}. Using capabilities of latest known Minecraft version {}.", version, LATEST.minecraftVersion());
LOG.info("Failed to parse MC version from NeoForm version {}. Using capabilities of latest known Minecraft version {}.", version, LATEST.minecraftVersion());
return LATEST;
}
index = MinecraftVersionList.VERSIONS.indexOf(mcVersion);
if (index == -1) {
LOG.lifecycle("Parsed unknown MC version {} from NeoForm version {}. Using capabilities of latest known Minecraft version {} with an updated Minecraft version.", mcVersion, version, LATEST.minecraftVersion());
LOG.info("Parsed unknown MC version {} from NeoForm version {}. Using capabilities of latest known Minecraft version {} with an updated Minecraft version.", mcVersion, version, LATEST.minecraftVersion());
return LATEST.withMinecraftVersion(mcVersion);
}
}
Expand All @@ -188,7 +188,7 @@ static int indexOfForgeVersion(String version) {
public static VersionCapabilitiesInternal ofForgeVersion(String version) {
var index = indexOfForgeVersion(version);
if (index == -1) {
LOG.lifecycle("Failed to parse MC version from Forge version {}. Using capabilities of latest known Minecraft version.", version);
LOG.info("Failed to parse MC version from Forge version {}. Using capabilities of latest known Minecraft version.", version);
return LATEST;
}

Expand Down
Loading