[26.1] Add conditional model loader#3184
Open
XFactHD wants to merge 1 commit into
Open
Conversation
XFactHD
added
enhancement
|
XFactHD
force-pushed
the
conditional_model_loader
branch
from
01dd4a9 to
35a55df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the conditional model loader which allows guarding a model behind loading conditions. This is primarily intended for models referencing textures from other mods which may not be present in order to reduce the amount of "missing texture" log spam at resource (re)load.
If needed, the loader can be extended to also support loading a model from a nested JSON object. This would allow guarding a model which uses yet another, potentially missing loader. Allowing the "primary" model to be a reference to another file however cannot be added as it would defeat the whole purpose of this loader.