NES: Add cart status for Sunsoft FME-7#180
Open
HeeminTV wants to merge 2 commits into
Open
Conversation
SourMesen
requested changes
Jun 20, 2026
| bool _irqEnabled = false; | ||
| bool _irqCounterEnabled = false; | ||
| uint16_t _irqCounter = 0; | ||
| uint8_t _regForStatus[16] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; // only used for status display |
Collaborator
There was a problem hiding this comment.
I would rename this to just "_regs" (other mappers have a similar pattern) and serialize it to save states in Serialize. If it's not in save states, rewinding or loading save states will display incorrect data in the register viewer.
There was a problem hiding this comment.
Personally, I'd rather go straight for a uint8_t _chrPage[8]; and, uint8_t _prgPage[3];. _regs[8] already exists as _workRamValue in a similar fashion.
SourMesen
reviewed
Jun 20, 2026
| entries.push_back(MapperStateEntry("", "PRG Bank 3", _regForStatus[11] & 0x3F, MapperStateValueType::Number8)); | ||
|
|
||
| entries.push_back(MapperStateEntry("", "PRG Bank 0 is RAM", (_regForStatus[8] & 0x40) == 0x40, MapperStateValueType::Bool)); | ||
| entries.push_back(MapperStateEntry("", "RAM enable", (_regForStatus[8] & 0x80) == 0x80, MapperStateValueType::Bool)); |
Collaborator
There was a problem hiding this comment.
should be RAM Enabled (capital E and 'd' at the end) to match e.g IRQ Enabled
…serialize viewer status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a register viewer menu for FME-7.