Skip to content

NES: Fix mapper 121, 187's CHR A18 behavior #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fiskbit merged 1 commit into from
Jun 23, 2026
+2 −2
Merged

NES: Fix mapper 121, 187's CHR A18 behavior #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/NES/Mappers/Mmc3Variants/MMC3_121.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class MMC3_121 : public MMC3
//Hack for Super 3-in-1
BaseMapper::SelectChrPage(slot, page | ((_exRegs[3] & 0x80) << 1), memoryType);
} else {
if((slot < 4 && _chrMode == 0) || (slot >= 4 && _chrMode == 1)) {
if(slot >= 4) {
page |= 0x100;
}
BaseMapper::SelectChrPage(slot, page, memoryType);
Expand Down
2 changes: 1 addition & 1 deletion Core/NES/Mappers/Mmc3Variants/MMC3_187.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class MMC3_187 : public MMC3

void SelectChrPage(uint16_t slot, uint16_t page, ChrMemoryType memoryType = ChrMemoryType::Default) override
{
if((_chrMode && slot >= 4) || (!_chrMode && slot < 4)) {
if(slot >= 4) {
page |= 0x100;
}
BaseMapper::SelectChrPage(slot, page);
Expand Down
Loading