Skip to content

GBA: fix Sprite Viewer vertical mirror on sprites without matrix transform #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SourMesen merged 2 commits into from
Jun 23, 2026
+2 −3
Merged

GBA: fix Sprite Viewer vertical mirror on sprites without matrix transform #188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59c02f3
Update GbaPpuTools.cpp
CharlesVanEeckhout Jun 23, 2026
09c500e
oops clang format
CharlesVanEeckhout Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Core/GBA/Debugger/GbaPpuTools.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,8 +511,6 @@ void GbaPpuTools::GetSpriteInfo(DebugSpriteInfo& sprite, uint32_t* spritePreview
int16_t centerY = 0;

for(int y = 0; y < sprite.Height; y++) {
uint8_t yOffset = vMirror ? (sprite.Height - y - 1) : y;

if(transformEnabled) {
uint16_t transformAddr = (sprite.TransformParamIndex << 5) + 6;
pa = oam[transformAddr] | (oam[transformAddr + 1] << 8);
Expand All @@ -525,6 +523,7 @@ void GbaPpuTools::GetSpriteInfo(DebugSpriteInfo& sprite, uint32_t* spritePreview

int32_t originX = -(centerX << (uint8_t)doubleSize);
int32_t originY = -(centerY << (uint8_t)doubleSize);
uint8_t yOffset = vMirror ? (sprite.Height - y - 1) : y;

xValue = originX * pa + (originY + yOffset) * pb;
yValue = originX * pc + (originY + yOffset) * pd;
Expand All @@ -542,7 +541,7 @@ void GbaPpuTools::GetSpriteInfo(DebugSpriteInfo& sprite, uint32_t* spritePreview
yValue += pc;
} else {
xRender = hMirror ? (width - x - 1) : x;
yRender = vMirror ? (height - yOffset - 1) : yOffset;
yRender = vMirror ? (height - y - 1) : y;
}

if(xRender >= width || yRender >= height) {
Expand Down
Loading