feat(PL-4041): actually use namespace #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are used by ArgoCD since they are passed to the chart, but they do not get rendered correctly in joy.
j-martin
requested review from
ayahajar,
davidmdm,
riclima and
silphid
as code owners
j-martin
requested review from
nwaller-nesto
and removed request for
a team,
alexstojda,
davidmdm,
riclima and
silphid
nwaller-nesto
approved these changes
Oct 15, 2025
nwaller-nesto
left a comment
nwaller-nesto
left a comment
There was a problem hiding this comment.
seems like a good fix and probably won't result in mass breakage
| ReleaseName: params.Release.Name, | ||
| ChartPath: params.Chart.DirName(), | ||
| Values: values, | ||
| Namespace: cmp.Or(params.Release.Spec.Namespace, params.Release.Environment.Spec.Namespace, "default"), |
| opts.ChartPath = strings.TrimPrefix(opts.ChartPath, "file://") | ||
|
|
||
| args := []string{"template", opts.ReleaseName, opts.ChartPath, "--values", "-", "--skip-tests"} | ||
| args := []string{"template", opts.ReleaseName, opts.ChartPath, "--values", "-", "--skip-tests", "--namespace", cmp.Or(opts.Namespace, "default")} |
Contributor
Author
There was a problem hiding this comment.
The thing is that we've been throwing everything in default, so nobody ever noticed.
davidmdm
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are used by ArgoCD since they are passed to the chart, but they do not get rendered correctly in joy.