Skip to content

feat(server): optional default for get_setting_value #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jokob-sk merged 1 commit into from
Jun 3, 2026
+7 −4
Merged

feat(server): optional default for get_setting_value #1669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions server/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def get_setting(key):

# -------------------------------------------------------------------------------
# Return setting value
def get_setting_value(key):
def get_setting_value(key, default=""):
"""
Retrieve a setting value from configuration.

Expand All @@ -208,13 +208,16 @@ def get_setting_value(key):

Args:
key (str): The setting key to look up.
default (Any): Value to return when the key is not found. Defaults
to "" for backwards compatibility with call sites that already
treat an empty string as "missing".

Returns:
Any: The Python-typed setting value, or an empty string if not found.
Any: The Python-typed setting value, or `default` if not found.
"""

# Returns empty string if not found
value = ""
# Returns default if not found
value = default

# lookup key in secondary cache
if key in SETTINGS_SECONDARYCACHE:
Expand Down
Loading