Next release#1670
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe PR reduces the default log retention length from 250,000 to 10,000 entries and updates the setting's documentation. Accompanying performance documentation explains the memory impact of large log files and guides users to adjust ChangesLog Size Optimization
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@front/plugins/maintenance/config.json`:
- Line 243: Update the description for MAINT_LOG_LENGTH to reflect that it
applies to multiple logs, not just app.log: reword the string to state that
MAINT_LOG_LENGTH limits the number of retained lines for app.log,
nginx-error.log and stdout.log (and that setting 0 disables purging), keep the
existing guidance about debug log volume and memory impact, and reference the
MAINT_LOG_LENGTH setting name so readers know which config key controls this
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e2c5f9c1-8427-4d9b-b1a9-2d41495bc8d8
⛔ Files ignored due to path filters (1)
docs/img/PERFORMANCE/logs_memory_usage.pngis excluded by!**/*.png
📒 Files selected for processing (2)
docs/PERFORMANCE.mdfront/plugins/maintenance/config.json
| { | ||
| "language_code": "en_us", | ||
| "string": "How many last <code>app.log</code> lines to keep. If <code>LOG_LEVEL</code> is set to <code>debug</code> the app generates about 10000 lines per hour, so when debugging an issue the recommended setting should cover the bug occurence timeframe. For example for a bug with a 3 day periodical appearence the value <code>1000000</code> should be sufficient. Setting this value to <code>1000000</code> generates approximatelly a 50MB <code>app.log</code> file. Set to <code>0</code> to disable log purging." | ||
| "string": "How many last <code>app.log</code> lines to keep. When <code>LOG_LEVEL</code> is set to <code>debug</code>, the application generates about 10,000 log lines per hour. Choose a value that covers the expected bug occurrence window. For example, <code>1000000</code> lines (~50 MB) is typically sufficient for issues that occur every 3 days. Set to <code>0</code> to disable log purging. Larger log files increase memory usage, so reduce this value after debugging is complete." |
There was a problem hiding this comment.
Widen description scope to match actual cleanup behavior.
Line 243 says this setting keeps app.log lines, but maintenance cleanup applies MAINT_LOG_LENGTH to multiple log files (app.log, nginx-error.log, stdout.log). Please reword this to avoid misleading retention expectations.
Suggested wording update
- "string": "How many last <code>app.log</code> lines to keep. When <code>LOG_LEVEL</code> is set to <code>debug</code>, the application generates about 10,000 log lines per hour. Choose a value that covers the expected bug occurrence window. For example, <code>1000000</code> lines (~50 MB) is typically sufficient for issues that occur every 3 days. Set to <code>0</code> to disable log purging. Larger log files increase memory usage, so reduce this value after debugging is complete."
+ "string": "How many last log lines to keep per maintained log file (for example <code>app.log</code>, <code>nginx-error.log</code>, and <code>stdout.log</code>). When <code>LOG_LEVEL</code> is set to <code>debug</code>, the application generates about 10,000 log lines per hour. Choose a value that covers the expected bug occurrence window. For example, <code>1000000</code> lines (~50 MB) is typically sufficient for issues that occur every 3 days. Set to <code>0</code> to disable log purging. Larger log files increase memory usage, so reduce this value after debugging is complete."📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "string": "How many last <code>app.log</code> lines to keep. When <code>LOG_LEVEL</code> is set to <code>debug</code>, the application generates about 10,000 log lines per hour. Choose a value that covers the expected bug occurrence window. For example, <code>1000000</code> lines (~50 MB) is typically sufficient for issues that occur every 3 days. Set to <code>0</code> to disable log purging. Larger log files increase memory usage, so reduce this value after debugging is complete." | |
| "string": "How many last log lines to keep per maintained log file (for example <code>app.log</code>, <code>nginx-error.log</code>, and <code>stdout.log</code>). When <code>LOG_LEVEL</code> is set to <code>debug</code>, the application generates about 10,000 log lines per hour. Choose a value that covers the expected bug occurrence window. For example, <code>1000000</code> lines (~50 MB) is typically sufficient for issues that occur every 3 days. Set to <code>0</code> to disable log purging. Larger log files increase memory usage, so reduce this value after debugging is complete." |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@front/plugins/maintenance/config.json` at line 243, Update the description
for MAINT_LOG_LENGTH to reflect that it applies to multiple logs, not just
app.log: reword the string to state that MAINT_LOG_LENGTH limits the number of
retained lines for app.log, nginx-error.log and stdout.log (and that setting 0
disables purging), keep the existing guidance about debug log volume and memory
impact, and reference the MAINT_LOG_LENGTH setting name so readers know which
config key controls this behavior.
Summary by CodeRabbit
Documentation
Chores