Fix faulty IP address DNS check #1514
Open
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#1444
New Behavior
Check for no IP address being available
Contrast to Current Behavior
Current behavior breaks inventory sync if the primary IP is not on one of the interfaces when checking for DNS. If you're not using the DNS feature, then this is the same as having None.
Discussion: Benefits and Drawbacks
This breaks our inventory sync periodically when there is dirty data left behind in our Netbox. Since we're not using the DNS feature and we don't need to check.
However, this will hide the issue where the primary IP is not on any interface.
Changes to the Documentation
None
Proposed Release Note Entry
Fix sync error when primary IP address not on interfaces
Double Check
develbranch.